public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V4 6/7] mmc: add bcm2835 driver
Date: Tue, 27 Nov 2012 07:49:08 +0100	[thread overview]
Message-ID: <20121127074908.655934a1@lilith> (raw)
In-Reply-To: <1353991097-12918-6-git-send-email-swarren@wwwdotorg.org>

On Mon, 26 Nov 2012 21:38:16 -0700, Stephen Warren
<swarren@wwwdotorg.org> wrote:

> This adds a simple driver for the BCM2835's SD controller.
> 
> Workarounds are implemented for:
> * Register writes can't be too close to each-other in time, or they will
>   be lost.
> * Register accesses must all be 32-bit, so implement custom accessors.
> 
> This code was extracted from:
> git://github.com/gonzoua/u-boot-pi.git master
> which was created by Oleksandr Tymoshenko.
> 
> Portions of the code there were obviously based on the Linux kernel at:
> git://github.com/raspberrypi/linux.git rpi-3.6.y
> commit f5b930b "Main bcm2708 linux port" signed-off-by Dom Cobley.
> 
> swarren changed the following for upstream:
> * Removed hack udelay()s in bcm2835_sdhci_raw_writel(); setting
>   SDHCI_QUIRK_WAIT_SEND_CMD appears to solve the issues.
> * Remove register logging from read*/write* functions.
> * Sort out confusion with min/max_freq values passed to add_sdhci().
> * Use more descriptive variable names and calculations in IO accessors.
> * Simplified and commented twoticks_delay calculation.
> * checkpatch fixes.
> 
> Cc: Andy Fleming <afleming@gmail.com>

Hi Andy,

As soon as you give your Ack to this patch, I'll apply the
whole series to u-boot-arm/master.

Amicalement,
-- 
Albert.

  reply	other threads:[~2012-11-27  6:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-27  4:38 [U-Boot] [PATCH V4 1/7] ARM: bcm2835: add mailbox driver Stephen Warren
2012-11-27  4:38 ` [U-Boot] [PATCH V4 2/7] ARM: rpi_b: use bcm2835 mbox driver to get memory size Stephen Warren
2012-11-27  4:38 ` [U-Boot] [PATCH V4 3/7] lcd: calculate line_length after lcd_ctrl_init() Stephen Warren
2012-11-27  4:38 ` [U-Boot] [PATCH V4 4/7] ARM: rpi_b: disable rpi_b dcache explicitly Stephen Warren
2012-11-27  4:38 ` [U-Boot] [PATCH V4 5/7] video: add a driver for the bcm2835 Stephen Warren
2012-11-27  4:38 ` [U-Boot] [PATCH V4 6/7] mmc: add bcm2835 driver Stephen Warren
2012-11-27  6:49   ` Albert ARIBAUD [this message]
2012-11-27 16:32     ` Stephen Warren
2012-11-27 18:37       ` Albert ARIBAUD
2012-11-27  7:23   ` Andy Fleming
2012-11-27  4:38 ` [U-Boot] [PATCH V4 7/7] ARM: rpi_b: enable SD controller, add related env/cmds Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121127074908.655934a1@lilith \
    --to=albert.u.boot@aribaud.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox