From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Tue, 27 Nov 2012 19:37:45 +0100 Subject: [U-Boot] [PATCH V4 6/7] mmc: add bcm2835 driver In-Reply-To: <50B4EB1B.60907@wwwdotorg.org> References: <1353991097-12918-1-git-send-email-swarren@wwwdotorg.org> <1353991097-12918-6-git-send-email-swarren@wwwdotorg.org> <20121127074908.655934a1@lilith> <50B4EB1B.60907@wwwdotorg.org> Message-ID: <20121127193745.07efde25@lilith> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Stephen, On Tue, 27 Nov 2012 09:32:27 -0700, Stephen Warren wrote: > On 11/26/2012 11:49 PM, Albert ARIBAUD wrote: > > On Mon, 26 Nov 2012 21:38:16 -0700, Stephen Warren > > wrote: > > > >> This adds a simple driver for the BCM2835's SD controller. > >> > >> Workarounds are implemented for: > >> * Register writes can't be too close to each-other in time, or they will > >> be lost. > >> * Register accesses must all be 32-bit, so implement custom accessors. > >> > >> This code was extracted from: > >> git://github.com/gonzoua/u-boot-pi.git master > >> which was created by Oleksandr Tymoshenko. > >> > >> Portions of the code there were obviously based on the Linux kernel at: > >> git://github.com/raspberrypi/linux.git rpi-3.6.y > >> commit f5b930b "Main bcm2708 linux port" signed-off-by Dom Cobley. > >> > >> swarren changed the following for upstream: > >> * Removed hack udelay()s in bcm2835_sdhci_raw_writel(); setting > >> SDHCI_QUIRK_WAIT_SEND_CMD appears to solve the issues. > >> * Remove register logging from read*/write* functions. > >> * Sort out confusion with min/max_freq values passed to add_sdhci(). > >> * Use more descriptive variable names and calculations in IO accessors. > >> * Simplified and commented twoticks_delay calculation. > >> * checkpatch fixes. > >> > >> Cc: Andy Fleming > > > > Hi Andy, > > > > As soon as you give your Ack to this patch, I'll apply the > > whole series to u-boot-arm/master. > > Do feel free to apply all the patches before the MMC driver addition > without waiting for the MMC driver though. You're right. I'll apply 1 to 5 and wait for Andy's comment to be taken into account for applying 6 and 7, possibly in a newer version. Amicalement, -- Albert.