[U-Boot] [PATCH 2/2] tegra: enable LCD on PAZ00

Marc Dietrich
2012-11-26T21:00:40Z

On Monday 26 November 2012 12:00:51 Stephen Warren wrote:
> On 11/25/2012 02:26 PM, Marc Dietrich wrote:
> > This adds LCD panel descriptions to the device tree of PAZ00 and
> > enables LCD support in the configuration.
> >
> > diff --git a/include/configs/paz00.h b/include/configs/paz00.h
> >
> > +#define CONFIG_BOARD_LATE_INIT
>
> What's that for? I don't think any of the other Tegra boards have it.

No, all board defining CONFIG_LCD have this (seaboard, avionics). You may ask
Simon why it is required. Without it, backlight will not come up on PAZ00 at
least.

> > /* SD/MMC */
> > #define CONFIG_MMC
> >
> > @@ -71,6 +72,20 @@
> >
> > #define CONFIG_CMD_NET
> > #define CONFIG_CMD_DHCP
> >
> > +#undef TEGRA_DEVICE_SETTINGS
> > +#define TEGRA_DEVICE_SETTINGS \
> > + "stdin=serial\0" \
> > + "stdout=serial,lcd\0" \
> > + "stderr=serial,lcd\0"
>
> Why not extend tegra-common-post.h's automatic calculation of
> TEGRA_DEVICE_SETTINGS to support the lcd case too? Allen Martin's recent
> change "tegra: move TEGRA_DEVICE_SETTINGS to tegra-common-post.h" should
> make it easy to do that.

Yes, I have such a patch in my gitorious tree for some time now. Allen's patch
is not in any u-boot-tegra branch yet. I can fix it up when it has landed.

Marc