From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 8/9] Issue connect/disconnect as appropriate
Date: Wed, 28 Nov 2012 03:50:56 +0100 [thread overview]
Message-ID: <201211280350.56773.marex@denx.de> (raw)
In-Reply-To: <1354106642-4587-9-git-send-email-panto@antoniou-consulting.com>
Dear Pantelis Antoniou,
> Call usb_gadget_connect/usb_gadget_disconnect in g_dnl_bind/g_dnl_unbind.
>
> Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com>
[...]
u-boot$ ./tools/checkpatch.pl \[PATCH\ 8_9\]\ Issue\ connect_disconnect\ as\
appropriate.mbox
WARNING: line over 80 characters
#57: FILE: drivers/usb/gadget/g_dnl.c:88:
+ debug("%s: calling usb_gadget_disconnect for controller '%s'\n",
shortname, gadget->name);
WARNING: line over 80 characters
#67: FILE: drivers/usb/gadget/g_dnl.c:160:
+ debug("%s: calling usb_gadget_connect for controller '%s'\n", shortname,
gadget->name);
total: 0 errors, 2 warnings, 21 lines checked
NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX
MULTISTATEMENT_MACRO_USE_DO_WHILE
[PATCH 8_9] Issue connect_disconnect as appropriate.mbox has style problems,
please review.
If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
... fix the other patches too
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-11-28 2:50 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-28 12:43 [U-Boot] [PATCH 0/9] DFU on am35xx_evm (against u-boot-usb) Pantelis Antoniou
2012-11-28 12:43 ` [U-Boot] [PATCH 1/9] Remove obsolete header file Pantelis Antoniou
2012-11-27 16:45 ` Tom Rini
2012-11-27 22:00 ` Marek Vasut
2012-11-28 3:01 ` Tom Rini
2012-11-28 12:43 ` [U-Boot] [PATCH 2/9] Fix bug when both DFU & ETHER are defined Pantelis Antoniou
2012-11-28 2:43 ` Marek Vasut
2012-11-28 8:24 ` Pantelis Antoniou
2012-11-29 6:30 ` Marek Vasut
2012-11-28 12:43 ` [U-Boot] [PATCH 3/9] Only perform DFU board_usb_init() for TRATS Pantelis Antoniou
2012-11-28 2:45 ` Marek Vasut
2012-11-28 8:26 ` Pantelis Antoniou
2012-11-29 6:28 ` Marek Vasut
2012-11-28 12:43 ` [U-Boot] [PATCH 4/9] Fix crash when wrong number of arguments given Pantelis Antoniou
2012-11-28 12:43 ` [U-Boot] [PATCH 5/9] Generate appropriate responses for DFU Pantelis Antoniou
2012-11-28 2:46 ` Marek Vasut
2012-11-28 8:27 ` Pantelis Antoniou
2012-11-28 12:43 ` [U-Boot] [PATCH 6/9] Properly zero out timeout value Pantelis Antoniou
2012-11-28 2:46 ` Marek Vasut
2012-11-28 8:28 ` Pantelis Antoniou
2012-11-28 10:23 ` Marek Vasut
2012-11-28 12:44 ` [U-Boot] [PATCH 7/9] Add a partition type target Pantelis Antoniou
2012-11-28 2:48 ` Marek Vasut
2012-11-28 8:31 ` Pantelis Antoniou
2012-11-28 9:22 ` Marek Vasut
2012-11-28 12:44 ` [U-Boot] [PATCH 8/9] Issue connect/disconnect as appropriate Pantelis Antoniou
2012-11-28 2:50 ` Marek Vasut [this message]
2012-11-28 3:03 ` Tom Rini
2012-11-28 12:44 ` [U-Boot] [PATCH 9/9] Add DFU config Pantelis Antoniou
2012-11-28 2:52 ` Marek Vasut
2012-11-28 3:04 ` Tom Rini
2012-11-28 8:32 ` Pantelis Antoniou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201211280350.56773.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox