From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Date: Wed, 28 Nov 2012 16:20:03 +0100 Subject: [U-Boot] [PATCH 04/10] g_dnl: Properly terminate string list. In-Reply-To: <1354174439-5589-5-git-send-email-panto@antoniou-consulting.com> References: <1354174439-5589-1-git-send-email-panto@antoniou-consulting.com> <1354174439-5589-5-git-send-email-panto@antoniou-consulting.com> Message-ID: <20121128162003.3de91d04@amdc308.digital.local> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Pantelis, > Well, not terminating the list causes very interesting crashes. > As in changing the vendor & product ID crashes. Fun. > > Signed-off-by: Pantelis Antoniou > --- > drivers/usb/gadget/g_dnl.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/gadget/g_dnl.c b/drivers/usb/gadget/g_dnl.c > index 25da733..a5a4c1f 100644 > --- a/drivers/usb/gadget/g_dnl.c > +++ b/drivers/usb/gadget/g_dnl.c > @@ -69,6 +69,7 @@ static struct usb_device_descriptor device_desc = { > static struct usb_string g_dnl_string_defs[] = { > { 0, manufacturer, }, > { 1, product, }, > + { } /* end of list */ Thanks for spotting. > }; > > static struct usb_gadget_strings g_dnl_string_tab = { Acked-by: Lukasz Majewski -- Best regards, Lukasz Majewski Samsung Poland R&D Center | Linux Platform Group