From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Thu, 29 Nov 2012 09:20:03 +0100
Subject: [U-Boot] [PATCH 04/10] g_dnl: Properly terminate string list.
In-Reply-To: <1354174439-5589-5-git-send-email-panto@antoniou-consulting.com>
References: <1354174439-5589-1-git-send-email-panto@antoniou-consulting.com>
	<1354174439-5589-5-git-send-email-panto@antoniou-consulting.com>
Message-ID: <201211290920.03861.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Pantelis Antoniou,

> Well, not terminating the list causes very interesting crashes.
> As in changing the vendor & product ID crashes. Fun.
> 
> Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com>
> ---
>  drivers/usb/gadget/g_dnl.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/gadget/g_dnl.c b/drivers/usb/gadget/g_dnl.c
> index 25da733..a5a4c1f 100644
> --- a/drivers/usb/gadget/g_dnl.c
> +++ b/drivers/usb/gadget/g_dnl.c
> @@ -69,6 +69,7 @@ static struct usb_device_descriptor device_desc = {
>  static struct usb_string g_dnl_string_defs[] = {
>  	{ 0, manufacturer, },
>  	{ 1, product, },
> +	{  }		/* end of list */

So you're adding an uninited entry here? How'll this work?

>  };
> 
>  static struct usb_gadget_strings g_dnl_string_tab = {

Best regards,
Marek Vasut