From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Thu, 29 Nov 2012 15:51:02 +0100 Subject: [U-Boot] [PATCH 2/2] net: add ICPlus PHY driver In-Reply-To: References: <1354097718-13775-1-git-send-email-yegorslists@googlemail.com> <201211291529.07010.marex@denx.de> Message-ID: <201211291551.02654.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Yegor Yefremov, > On Thu, Nov 29, 2012 at 3:29 PM, Marek Vasut wrote: > > Dear Yegor Yefremov, > > > >> On Thu, Nov 29, 2012 at 1:55 PM, Marek Vasut wrote: > >> > Dear Yegor Yefremov, > >> > > >> >> On Thu, Nov 29, 2012 at 8:53 AM, Henrik Nordstr?m > >> >> > >> >> wrote: > >> >> > tor 2012-11-29 klockan 07:27 +0100 skrev Marek Vasut: > >> >> >> Dear yegorslists at googlemail.com, > >> >> >> > >> >> >> > From: Yegor Yefremov > >> >> >> > > >> >> >> > The driver code was taken from Linux kernel source: > >> >> >> > drivers/net/phy/icplus.c > >> >> >> > > >> >> >> > Signed-off-by: Yegor Yefremov > >> >> >> > >> >> >> [...] > >> >> >> > >> >> >> Is there any user for this PHY please? > >> >> > > >> >> > I don't have one, but know at least one user having one in an A10 > >> >> > based "netbook". > >> >> > > >> >> > http://linux-sunxi.org/File:H6-netbook-mainboard.jpg > >> >> > >> >> I found these boards in kernel: > >> >> > >> >> arch/mips/configs/malta_defconfig:CONFIG_ICPLUS_PHY=m > >> >> arch/mips/configs/bcm47xx_defconfig:CONFIG_ICPLUS_PHY=m > >> >> arch/mips/configs/ip27_defconfig:CONFIG_ICPLUS_PHY=m > >> >> arch/mips/configs/sead3_defconfig:CONFIG_ICPLUS_PHY=y > >> >> arch/powerpc/configs/mpc512x_defconfig:CONFIG_ICPLUS_PHY=y > >> >> arch/powerpc/configs/52xx/motionpro_defconfig:CONFIG_ICPLUS_PHY=y > >> >> arch/powerpc/configs/83xx/mpc832x_rdb_defconfig:CONFIG_ICPLUS_PHY=y > >> >> arch/powerpc/configs/mpc83xx_defconfig:CONFIG_ICPLUS_PHY=y > >> >> arch/powerpc/configs/ppc6xx_defconfig:CONFIG_ICPLUS_PHY=m > >> > > >> > Sure, but the question/point is ... won't this be dead code in u-boot? > >> > It won't once you add at least one board that actually uses it ... > >> > adding it only so it's there will only cause it to bitrot and it'll > >> > actually only add more burden to maintainers. > >> > >> It won't be dead code, because we will use it :-) Our board is > >> derivative of BeagleBone & Co, so the whole support stuff is already > >> in u-boot. > > > > You need to enable it for that board though ;-) > > Will do this as soon as we come near to the release. Release of what? The hardware? > I'd like to have basic stuff mainlined before. Well, I'll leave that up to Joe anyway Best regards, Marek Vasut