From mboxrd@z Thu Jan  1 00:00:00 1970
From: Lukasz Majewski <l.majewski@samsung.com>
Date: Fri, 30 Nov 2012 18:10:30 +0100
Subject: [U-Boot] [PATCH 5/9] dfu: Fix crash when wrong number of
	arguments given
In-Reply-To: <1354294293-2801-6-git-send-email-panto@antoniou-consulting.com>
References: <1354294293-2801-1-git-send-email-panto@antoniou-consulting.com>
	<1354294293-2801-6-git-send-email-panto@antoniou-consulting.com>
Message-ID: <20121130181030.04d9b7b5@amdc308.digital.local>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Pantelis,

> Fix obvious crash when not enough arguments are given to the dfu
> command.
> 
> Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com>
> ---
>  common/cmd_dfu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/common/cmd_dfu.c b/common/cmd_dfu.c
> index 327c738..83ef324 100644
> --- a/common/cmd_dfu.c
> +++ b/common/cmd_dfu.c
> @@ -50,7 +50,7 @@ static int do_dfu(cmd_tbl_t *cmdtp, int flag, int
> argc, char * const argv[]) if (ret)
>  		return CMD_RET_FAILURE;
>  
> -	if (strcmp(argv[3], "list") == 0) {
> +	if (argc > 3 && strcmp(argv[3], "list") == 0) {
>  		dfu_show_entities();
>  		goto done;
>  	}

Why do you don't include changelog for your patches?

This is already v3, and I had comment to this patch in v2.
Unfortunately with no feedback from your side.

-- 
Best regards,

Lukasz Majewski

Samsung Poland R&D Center | Linux Platform Group