From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] mxs: Implement common function to setup VDDx
Date: Fri, 30 Nov 2012 19:35:44 +0100 [thread overview]
Message-ID: <201211301935.44998.marex@denx.de> (raw)
In-Reply-To: <CAP9ODKoXAnRCV2K0RGORDAiN4ptetPnvgJcJk1nUdHd3j1C_ZQ@mail.gmail.com>
Dear Otavio Salvador,
> On Fri, Nov 30, 2012 at 1:22 PM, Marek Vasut <marex@denx.de> wrote:
> > Implement common function to setup the VDDIO, VDDD and VDDA voltage.
> > Right now, there are two almost identical functions to setup VDDIO
> > and VDDD, which is prone to breakage. Pull out the differences into
> > constant structure and pass them as an argument to the common function.
> >
> > Moreover, the function has almost identical loops for setting higher
> > and lower VDDx voltage. Merge these two loops.
> >
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Stefano Babic <sbabic@denx.de>
> > Cc: Fabio Estevam <fabio.estevam@freescale.com>
>
> I like the code cleanup but I am curious if you have taken a look if the
> mx23 one is compatible.
MX23 is unsupported in the mainline u-boot.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-11-30 18:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-30 15:22 [U-Boot] [PATCH 1/2] mxs: Implement common function to setup VDDx Marek Vasut
2012-11-30 15:22 ` [U-Boot] [PATCH 2/2] mxs: Properly setup VDDD in power supply setup code Marek Vasut
2012-12-04 8:28 ` Stefano Babic
2012-11-30 18:23 ` [U-Boot] [PATCH 1/2] mxs: Implement common function to setup VDDx Otavio Salvador
2012-11-30 18:35 ` Marek Vasut [this message]
2012-11-30 18:39 ` Otavio Salvador
2012-12-04 8:28 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201211301935.44998.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox