From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Fri, 30 Nov 2012 19:35:44 +0100 Subject: [U-Boot] [PATCH 1/2] mxs: Implement common function to setup VDDx In-Reply-To: References: <1354288933-18926-1-git-send-email-marex@denx.de> Message-ID: <201211301935.44998.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Otavio Salvador, > On Fri, Nov 30, 2012 at 1:22 PM, Marek Vasut wrote: > > Implement common function to setup the VDDIO, VDDD and VDDA voltage. > > Right now, there are two almost identical functions to setup VDDIO > > and VDDD, which is prone to breakage. Pull out the differences into > > constant structure and pass them as an argument to the common function. > > > > Moreover, the function has almost identical loops for setting higher > > and lower VDDx voltage. Merge these two loops. > > > > Signed-off-by: Marek Vasut > > Cc: Stefano Babic > > Cc: Fabio Estevam > > I like the code cleanup but I am curious if you have taken a look if the > mx23 one is compatible. MX23 is unsupported in the mainline u-boot. Best regards, Marek Vasut