From mboxrd@z Thu Jan  1 00:00:00 1970
From: Luka Perkov <luka@openwrt.org>
Date: Sun, 2 Dec 2012 20:03:13 +0100
Subject: [U-Boot] [PATCH 01/10] ARM: dove: add support for Marvell Dove
 SoC
In-Reply-To: <1354458982-14403-2-git-send-email-sebastian.hesselbarth@gmail.com>
References: <1354458982-14403-1-git-send-email-sebastian.hesselbarth@gmail.com>
	<1354458982-14403-2-git-send-email-sebastian.hesselbarth@gmail.com>
Message-ID: <20121202190313-1245@mutt-kz>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Sebastian,

On Sun, Dec 02, 2012 at 03:36:13PM +0100, Sebastian Hesselbarth wrote:
> This patch adds initial support for the armv7-based Marvell Dove SoC
> (88AP510).
> 
> Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>

...

> +	for (; i < CONFIG_NR_DRAM_BANKS; i++) {
> +		/* If above loop terminated prematurely, we need to set
> +		 * remaining banks' start address & size as 0. Otherwise other
> +		 * u-boot functions and Linux kernel gets wrong values which
> +		 * could result in crash */

Please fix this comment style.

...

> +	/* configure gpio capabilities */
> +	/* gpio allows gpio on all audio1 mpp pins */

Here too.

Also, your patch to MAINTAINERS file is missing...

Luka