From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH resend] usbh/ehci: Increase timeout for enumeration
Date: Thu, 6 Dec 2012 18:36:24 +0100 [thread overview]
Message-ID: <201212061836.24450.marex@denx.de> (raw)
In-Reply-To: <6d67e42f17927a93540ee2c37364b9c85c2a2b06.1354775426.git.vipin.kumar@st.com>
Dear Vipin Kumar,
> Few pen drives take longer than usual for enumeration. The u-boot unlike
> linux does not depend on interrupts and works in polling and timeout mode.
Good, can you maybe poll the register instead of adding arbitrary delay which
will cause trouble to everyone even if they never ever use such broken hardware?
Besides, I fail to understand the logic in this patch. The commit message
doesn't explain it at all.
> This patch increases this timeout to increase the set of usb sticks that
> can be enumerated by u-boot
>
> Signed-off-by: Vipin Kumar <vipin.kumar@st.com>
[..]
Best regards,
Marek Vasut
prev parent reply other threads:[~2012-12-06 17:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-06 6:30 [U-Boot] [PATCH resend] usbh/ehci: Increase timeout for enumeration Vipin Kumar
2012-12-06 6:47 ` Igor Grinberg
2012-12-06 6:58 ` Vipin Kumar
2012-12-06 7:36 ` Igor Grinberg
2012-12-06 9:03 ` Vipin Kumar
2012-12-06 11:44 ` Igor Grinberg
2012-12-06 17:36 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201212061836.24450.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox