From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] universal_c210: fix compiler error and compiler warning
Date: Mon, 10 Dec 2012 10:06:42 +0100 [thread overview]
Message-ID: <20121210090642.5B787201212@gemini.denx.de> (raw)
In-Reply-To: <50C58623.3090308@samsung.com>
Dear Minkyu Kang,
In message <50C58623.3090308@samsung.com> you wrote:
...
> @@ -337,7 +341,7 @@ static void init_pmic_lcd(void)
> unsigned char val;
> int ret = 0;
>
> - struct pmic *p = get_pmic();
> + struct pmic *p = pmic_get("MAX8998_PMIC");
>
> if (pmic_probe(p))
> return;
> @@ -428,7 +432,7 @@ static void reset_lcd(void)
>
> static void lcd_power_on(void)
> {
> - struct pmic *p = get_pmic();
> + struct pmic *p = pmic_get("MAX8998_PMIC");
>
> if (pmic_probe(p))
> return;
This is unrelated to your patch - but what if pmic_get() returns NULL?
pmic_probe() will crashif you pass it a NULL pointer...
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Digital computers are themselves more complex than most things people
build: They have very large numbers of states. This makes conceiving,
describing, and testing them hard. Software systems have orders-of-
magnitude more states than computers do. - Fred Brooks, Jr.
next prev parent reply other threads:[~2012-12-10 9:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-10 6:50 [U-Boot] universal_c210: fix compiler error and compiler warning Minkyu Kang
2012-12-10 9:06 ` Wolfgang Denk [this message]
2012-12-10 9:32 ` Lukasz Majewski
2012-12-10 9:59 ` Minkyu Kang
2012-12-10 10:44 ` Wolfgang Denk
2012-12-10 10:28 ` Piotr Wilczek
2012-12-11 4:01 ` Minkyu Kang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121210090642.5B787201212@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox