From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] universal_c210: fix compiler error and compiler warning
Date: Mon, 10 Dec 2012 11:44:48 +0100 [thread overview]
Message-ID: <20121210104448.52307200FDD@gemini.denx.de> (raw)
In-Reply-To: <20121210103224.372c572e@amdc308.digital.local>
Dear Lukasz Majewski,
In message <20121210103224.372c572e@amdc308.digital.local> you wrote:
>
> > This is unrelated to your patch - but what if pmic_get() returns NULL?
> >
> > pmic_probe() will crashif you pass it a NULL pointer...
>
> The PMIC 2.0 uses malloc to allocate pmic structure.
...and malloc() can fail.
> The fix, which has been proposed would work for old pmic.
>
> In the new one PMIC 2.0, we require to test return pointer from
> pmic_get() (similar to all malloc allocations):
>
> struct pmic *p = pmic_get("MAX8998_PMIC");
> if (!p)
> return -ENODEV;
So this code here needs fixing. This is what I wanted to point out.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"If you want to eat hippopatomus, you've got to pay the freight." -
attributed to an IBM guy, about why IBM software uses so much memory
next prev parent reply other threads:[~2012-12-10 10:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-10 6:50 [U-Boot] universal_c210: fix compiler error and compiler warning Minkyu Kang
2012-12-10 9:06 ` Wolfgang Denk
2012-12-10 9:32 ` Lukasz Majewski
2012-12-10 9:59 ` Minkyu Kang
2012-12-10 10:44 ` Wolfgang Denk [this message]
2012-12-10 10:28 ` Piotr Wilczek
2012-12-11 4:01 ` Minkyu Kang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121210104448.52307200FDD@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox