public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Eric Bénard" <eric@eukrea.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] m28evk/mx28evk: fix nand_update_full
Date: Tue, 11 Dec 2012 09:50:37 +0100	[thread overview]
Message-ID: <20121211095037.718448a3@eb-e6520> (raw)
In-Reply-To: <1355180363.5334.16@snotra>

Hi Scott,

Le Mon, 10 Dec 2012 16:59:23 -0600,
Scott Wood <scottwood@freescale.com> a ?crit :

> On 12/10/2012 10:41:59 AM, Eric B?nard wrote:
> > - commit 418396e212b59bf907dbccad997ff50f7eb61b16 chenged the  
> > behaviour
> > of nand write.raw which now takes a pagecount as a parameter and no  
> > more
> > the size to be written so update the default environment of these  
> > boards
> > to fix the problem.
> 
> It never really took the size to be written -- the size was implicitly  
> one page before.  It looks like there may have been a bug in the old  
> code, where common code expected a size to be there anyway, even though  
> it was ignored other than for error checking.
> 
true, before the size was forced to one page :
rwsize = nand->writesize + nand->oobsize;
now it's rwsize = pagecount * (nand->writesize + nand->oobsize);
so the size parameter in this script was ignored and now leads to a
wrong rwsize calculation.

Do you want me to rephrase the commit log or will you take it as is ?

Eric

  reply	other threads:[~2012-12-11  8:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-10 16:41 [U-Boot] [PATCH] m28evk/mx28evk: fix nand_update_full Eric Bénard
2012-12-10 16:49 ` Marek Vasut
2012-12-10 22:59 ` Scott Wood
2012-12-11  8:50   ` Eric Bénard [this message]
2012-12-11 17:10     ` Scott Wood
2012-12-11 21:36       ` [U-Boot] [PATCH v2] " Eric Bénard
2012-12-11 23:25         ` Scott Wood
2012-12-12  3:05           ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121211095037.718448a3@eb-e6520 \
    --to=eric@eukrea.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox