From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Tue, 11 Dec 2012 15:40:09 -0700 Subject: [U-Boot] [PATCH] [DFU] Implement NAND dfu support In-Reply-To: <1355264677.13481.13@snotra> References: <1355153072-6047-1-git-send-email-panto@antoniou-consulting.com> <1355188195.5334.24@snotra> <20121211011650.GV9044@bill-the-cat> <1355264677.13481.13@snotra> Message-ID: <20121211224009.GA32714@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, Dec 11, 2012 at 04:24:37PM -0600, Scott Wood wrote: > On 12/10/2012 07:16:50 PM, Tom Rini wrote: > >On Mon, Dec 10, 2012 at 07:09:55PM -0600, Scott Wood wrote: > >> On 12/10/2012 09:24:32 AM, Pantelis Antoniou wrote: > >> >+ sprintf(cmd_buf, "nand %s %p %llx %llx", > >> >+ op == DFU_OP_READ ? "read" : "write", > >> >+ buf, start, count); > >> >+ > >> >+ debug("%s: %s 0x%p\n", __func__, cmd_buf, cmd_buf); > >> >+ ret = run_command(cmd_buf, 0); > >> > >> Why not use the C interface to NAND? > >> > >> >+ /* find out how much actual bytes have been written */ > >> >+ /* the difference is the amount of skip we must add from now on > >> >*/ > >> >+ actual = nand_extent_skip_bad(&nand_info[dev], start, count); > >> > >> ...especially since you already need to interact with it here? > > > >I've been talking with Pantelis about this as well and in short, this > >series adds NAND support ala MMC (which is to say, (ab)using the > >command > >interface). I think he was thinking we need a bit more generic > >help to > >avoid having to duplicate the code the command interface also uses > >(state, sanity checking), iirc. > > Some elaboration on what exactly he's relying on from the command > line interface would be nice. My gmane-fu is failing me, but the actual 4/7 parts of http://search.gmane.org/?query=dfu+mmc+%224%2F7%22&author=&group=gmane.comp.boot-loaders.u-boot&sort=revdate&DEFAULTOP=and&%3E=Next&xP=Zdfu%09Zmmc%094%097&xFILTERS=Gcomp.boot-loaders.u-boot---A show the discussion. In short, for MMC writing it's more complex because we have a number of layouts we need to deal with (raw, FAT, other), but yes, we should in the end migrate things to using the API rather than abusing the command infrastructure. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: