From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Wed, 12 Dec 2012 04:05:06 +0100 Subject: [U-Boot] [PATCH v2] m28evk/mx28evk: fix nand_update_full In-Reply-To: <1355268343.16025.2@snotra> References: <1355245805.13481.0@snotra> <1355261781-3701-1-git-send-email-eric@eukrea.com> <1355268343.16025.2@snotra> Message-ID: <201212120405.06766.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Scott Wood, > On 12/11/2012 03:36:21 PM, Eric B?nard wrote: > > - since commit 418396e212b59bf907dbccad997ff50f7eb61b16 nand write.raw > > can take the number of page to be written as an argument. > > nand_update_full > > is passing the size (in bytes) to nand write.raw. This value was > > previously > > ignored but now breaks the write. > > - this patch updates the default environment of these boards to > > provide a > > pagecount instead of a size to nand write.raw. > > - tested on a mx28evk with a 4k page NAND and on a custom board with a > > 2k page NAND. > > > > Signed-off-by: Eric B?nard > > Cc: Marek Vasut > > Cc: Fabio Estevam > > --- > > > > include/configs/m28evk.h | 2 +- > > include/configs/mx28evk.h | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > Marek, can you ack this? > > There is still a change in behavior in that before > 418396e212b59bf907dbccad997ff50f7eb61b16 it only wrote one page (since > that's all the write.raw command ever did) but with this patch it will > write ${fcb_sz} pages. I assume the new behavior is correct? Yes, it's correct Acked-by: Marek Vasut Best regards, Marek Vasut