From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] usbh/ehci: Increase timeout for enumeration
Date: Wed, 12 Dec 2012 12:25:11 +0100 [thread overview]
Message-ID: <201212121225.11667.marex@denx.de> (raw)
In-Reply-To: <50C8543F.8000508@st.com>
Dear Vipin Kumar,
> >> + ulong start = get_timer(0);
> >> +
> >> + do {
> >> + ret = usb_get_port_status(dev, i + 1, portsts);
> >> + if (ret< 0) {
> >> + USB_HUB_PRINTF("get_port_status failed\n");
> >> + break;
> >> + }
> >> +
> >> + portstatus = le16_to_cpu(portsts->wPortStatus);
> >> + portchange = le16_to_cpu(portsts->wPortChange);
> >> +
> >> + if ((portchange& USB_PORT_STAT_C_CONNECTION) ==
> >> + (portstatus& USB_PORT_STAT_CONNECTION))
> >
> > I don't know if there is any corner case when the above check
> > will always fail and so it will always wait a maximal delay time.
> > Are those registers that identical, or can there be differences?
> >
> >> + break;
> >> +
> >> + mdelay(100);
> >> + } while (get_timer(start)< CONFIG_SYS_HZ * 10);
> >
> > Is there any justification for the CONFIG_SYS_HZ * 10?
> > I would be much more fine with this patch if there were any
> > (even just test based * 2) reason for that number.
>
> Not really. Just a practical test.
> Marek, can I have comments from you as well
>
Sorry, I'm really busy these days. I went through it and I see Igor still has
some comment. Just fix that one and I'm good.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-12-12 11:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-07 8:58 [U-Boot] [PATCH v2] usbh/ehci: Increase timeout for enumeration Vipin Kumar
2012-12-07 10:03 ` Igor Grinberg
2012-12-07 10:18 ` Igor Grinberg
2012-12-07 10:32 ` Vipin Kumar
2012-12-12 9:54 ` Vipin Kumar
2012-12-12 11:25 ` Marek Vasut [this message]
2012-12-13 6:11 ` Vipin Kumar
2012-12-12 11:40 ` Igor Grinberg
2012-12-12 12:00 ` Vipin Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201212121225.11667.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox