From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 7/8] TMU: Add u-boot command to read current temp
Date: Wed, 12 Dec 2012 21:26:10 +0100 [thread overview]
Message-ID: <20121212202610.80F10200FD0@gemini.denx.de> (raw)
In-Reply-To: <CAPnjgZ18daUnwQtAxtPOU43EGLA7=tN0EFUtbBzKNTDY8DA-sQ@mail.gmail.com>
Dear Simon Glass,
In message <CAPnjgZ18daUnwQtAxtPOU43EGLA7=tN0EFUtbBzKNTDY8DA-sQ@mail.gmail.com> you wrote:
>
> > Do we really need a new command here?
> >
> > We already have dtt, which basicly does the same.
> >
> > It makes no sense to add new commands for each new device, all doing
> > basicly trhe same, just in an incompatible way.
>
> This patch feature does not use i2c as the temperature measurement is
> inside the SOC. I wonder whether cmd_dtt.c could be extended so that
> it only does the i2c stuff if CONFIG_SYS_DTT_BUS_NUM is defined. Then
> you could use dtt_get_temp() to get the termperature as now.
Dtt should actually be completely agnostic of the underlying method to
access the devices it operates on. If such generalization is needed
now, then yes, it should be added.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"I used to think that the brain was the most wonderful organ in my
body. Then I realized who was telling me this." - Emo Phillips
next prev parent reply other threads:[~2012-12-12 20:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-11 10:54 [U-Boot] [PATCH 0/8 v4] Add TMU support for Exynos5250 based SMDK5250 Hatim Ali
2012-12-11 10:54 ` [U-Boot] [PATCH 1/8] EXYNOS5: FDT: Add TMU device node values Hatim Ali
2012-12-12 14:51 ` Simon Glass
2012-12-11 10:54 ` [U-Boot] [PATCH 2/8] EXYNOS5: TMU: Add driver for Thermal Management Unit Hatim Ali
2012-12-11 12:41 ` Wolfgang Denk
2012-12-11 10:54 ` [U-Boot] [PATCH 3/8] EXYNOS5: Power down API " Hatim Ali
2012-12-11 12:43 ` Wolfgang Denk
2012-12-12 14:00 ` Simon Glass
2012-12-12 20:27 ` Wolfgang Denk
2012-12-11 10:54 ` [U-Boot] [PATCH 4/8] Add a poll function to monitor events Hatim Ali
2012-12-11 12:39 ` Wolfgang Denk
2012-12-12 14:14 ` Simon Glass
2012-12-12 20:44 ` Wolfgang Denk
2012-12-12 21:07 ` Simon Glass
2012-12-12 22:11 ` Wolfgang Denk
2012-12-12 23:34 ` Simon Glass
2012-12-13 10:23 ` Wolfgang Denk
2012-12-11 10:54 ` [U-Boot] [PATCH 5/8] EXYNOS5: TMU: Add TMU status polling Hatim Ali
2012-12-11 10:54 ` [U-Boot] [PATCH 6/8] EXYNOS5: Config: Enable support for Exynos TMU driver Hatim Ali
2012-12-11 10:54 ` [U-Boot] [PATCH 7/8] TMU: Add u-boot command to read current temp Hatim Ali
2012-12-11 12:30 ` Wolfgang Denk
2012-12-12 13:57 ` Simon Glass
2012-12-12 20:26 ` Wolfgang Denk [this message]
2012-12-11 10:54 ` [U-Boot] [PATCH 8/8] EXYNOS5: Config: Enable tmu command Hatim Ali
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121212202610.80F10200FD0@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox