From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Thu, 13 Dec 2012 14:11:17 +0100 Subject: [U-Boot] [PATCH v3] usbh/ehci: Increase timeout for enumeration In-Reply-To: <98a900ae65d11e2bca6addcfc16675de1d665d59.1355396006.git.vipin.kumar@st.com> References: <98a900ae65d11e2bca6addcfc16675de1d665d59.1355396006.git.vipin.kumar@st.com> Message-ID: <201212131411.18016.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Vipin Kumar, > The current logic reads the port status just once after usb_hub_power_on > and expects the portstatus and portchange to report the connection status > immediately and correctly. > > Few pen drives are not able to report both of them immediately ie. those > pens report the connection change but not the connected state after the > first read. This opportunity once lost is gone for ever because the > u-boot, unlike linux or any other OS, works in polling mode. > > This patch modifies the logic to read the port status continuously until > the portstatus and portchange both report a connection change as well as a > connected state or no connection change and no connection. This logic is > placed in a timeout of 10 sec. At the end of it, the pen drive would have > either reported a ONE or a ZERO in bit 1 of portstatus as well as > portchange. > > It enhances the set of pen drives which can eventually be detected by > u-boot > > Note: This 10 second timeout is based purely on several experiments done > with the broken pen drives > > Signed-off-by: Vipin Kumar > Acked-by: Igor Grinberg Applied, tested. Thanks Best regards, Marek Vasut