From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 04/11] usb: ehci: Support interrupt transfers via periodic list
Date: Thu, 13 Dec 2012 18:32:45 +0100 [thread overview]
Message-ID: <201212131832.45987.marex@denx.de> (raw)
In-Reply-To: <1355363731-10103-5-git-send-email-sjg@chromium.org>
Dear Simon Glass,
> From: Patrick Georgi <patrick@georgi-clan.de>
>
> Interrupt transfers aren't meant to be used from the async list
> (the EHCI spec indicates trouble with low/full-speed intr on async).
>
> Build a periodic list instead, and provide an API to make use of it.
> Then, use that API from the existing interrupt transfer API.
>
> This provides support for USB keyboards using EHCI.
>
> Signed-off-by: Patrick Georgi <patrick@georgi-clan.de>
> Signed-off-by: Simon Glass <sjg@chromium.org>
[...]
Looks good in general. Clear up those ToDos please. Also, some while() cycles
are endless, make use of some timeout please.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-12-13 17:32 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-13 1:55 [U-Boot] [PATCH 0/11] Various USB improvements Simon Glass
2012-12-13 1:55 ` [U-Boot] [PATCH 01/11] usb: net: asix: Do a fast init if link already established Simon Glass
2012-12-13 17:26 ` Marek Vasut
2012-12-15 7:28 ` Joe Hershberger
2012-12-13 1:55 ` [U-Boot] [PATCH 02/11] usb: ehci: Add 64-bit controller support Simon Glass
2012-12-13 17:27 ` Marek Vasut
2012-12-13 1:55 ` [U-Boot] [PATCH 03/11] usb: ehci: generic PCI support Simon Glass
2012-12-13 17:30 ` Marek Vasut
2012-12-13 17:49 ` Vincent Palatin
2012-12-13 17:54 ` Marek Vasut
2012-12-14 1:41 ` Simon Glass
2012-12-14 6:58 ` [U-Boot] [PATCH v3 2/7] " Simon Glass
2012-12-13 1:55 ` [U-Boot] [PATCH 04/11] usb: ehci: Support interrupt transfers via periodic list Simon Glass
2012-12-13 17:32 ` Marek Vasut [this message]
2012-12-14 1:46 ` Simon Glass
2012-12-14 2:00 ` Marek Vasut
2012-12-14 2:05 ` Simon Glass
2012-12-13 1:55 ` [U-Boot] [PATCH 05/11] usb: ehci: Fix aliasing issue in EHCI interrupt code Simon Glass
2012-12-13 1:55 ` [U-Boot] [PATCH 06/11] usb: ehci: Add timeout on interrupt endpoint operations Simon Glass
2012-12-13 17:35 ` Marek Vasut
2012-12-14 2:04 ` Simon Glass
2012-12-13 1:55 ` [U-Boot] [PATCH 07/11] usb: usbeth: smsc95xx: remove EEPROM loaded check Simon Glass
2012-12-13 17:35 ` Marek Vasut
2012-12-13 1:55 ` [U-Boot] [PATCH 08/11] usb: Clean up newly allocated device nodes in case of configuration failure Simon Glass
2012-12-13 17:36 ` Marek Vasut
2012-12-13 1:55 ` [U-Boot] [PATCH 09/11] usb: properly detect empty mass storage media reader Simon Glass
2012-12-13 17:37 ` Marek Vasut
2012-12-13 1:55 ` [U-Boot] [PATCH 10/11] usb: Add multiple controllers support for EHCI PCI Simon Glass
2012-12-13 1:55 ` [U-Boot] [PATCH 11/11] x86: Enable USB features for coreboot Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201212131832.45987.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox