From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Thu, 13 Dec 2012 18:32:45 +0100
Subject: [U-Boot] [PATCH 04/11] usb: ehci: Support interrupt transfers
	via periodic list
In-Reply-To: <1355363731-10103-5-git-send-email-sjg@chromium.org>
References: <1355363731-10103-1-git-send-email-sjg@chromium.org>
	<1355363731-10103-5-git-send-email-sjg@chromium.org>
Message-ID: <201212131832.45987.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Simon Glass,

> From: Patrick Georgi <patrick@georgi-clan.de>
> 
> Interrupt transfers aren't meant to be used from the async list
> (the EHCI spec indicates trouble with low/full-speed intr on async).
> 
> Build a periodic list instead, and provide an API to make use of it.
> Then, use that API from the existing interrupt transfer API.
> 
> This provides support for USB keyboards using EHCI.
> 
> Signed-off-by: Patrick Georgi <patrick@georgi-clan.de>
> Signed-off-by: Simon Glass <sjg@chromium.org>
[...]

Looks good in general. Clear up those ToDos please. Also, some while() cycles 
are endless, make use of some timeout please.

Best regards,
Marek Vasut