From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, 1/2] spi: Add progress percentage and write speed to `sf update`
Date: Wed, 19 Dec 2012 13:43:28 -0700 [thread overview]
Message-ID: <20121219204328.GD14589@bill-the-cat> (raw)
In-Reply-To: <1348878482-1730-1-git-send-email-sjg@chromium.org>
On Fri, Sep 28, 2012 at 02:28:00PM -0000, Simon Glass wrote:
> From: James Miller <jamesmiller@chromium.org>
>
> Output a progress update only at most 10 times per second, to avoid
> saturating (and waiting on) the console. Make the summary line
> to fit on a single line. Make sure that cursor sits at the end of
> each update line instead of the beginning.
>
> Sample output:
>
> SF: Detected W25Q32 with page size 4 KiB, total 4 MiB
> Update SPI
> 1331200 bytes written, 2863104 bytes skipped in 21.912s, speed 199728 B/s
>
> time: 21.919 seconds, 21919 ticks
> Skipping verify
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> Signed-off-by: James Miller <jamesmiller@chromium.org>
> Signed-off-by: Taylor Hutt <thutt@chromium.org>
With ELDK 4.2:
cmd_sf.c:80: warning: type qualifiers ignored on function return type
Unless I'm missing something, this is the right fix:
-static const ulong bytes_per_second(unsigned int len, ulong start_ms)
+static ulong bytes_per_second(unsigned int len, ulong start_ms)
Because no, we aren't returning a const. If that sounds right I'll fix
inline and add my Signed-off-by.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20121219/cfdfea3a/attachment.pgp>
next prev parent reply other threads:[~2012-12-19 20:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-29 0:28 [U-Boot] [PATCH 1/2] spi: Add progress percentage and write speed to `sf update` Simon Glass
2012-09-29 0:28 ` [U-Boot] [PATCH 2/2] spi: Add SPI flash test Simon Glass
2012-10-01 17:32 ` Tom Rini
2012-10-08 23:00 ` Simon Glass
2012-10-08 23:03 ` Tom Rini
2012-12-19 23:12 ` Wolfgang Denk
2012-12-19 20:43 ` Tom Rini [this message]
2012-12-19 20:46 ` [U-Boot] [U-Boot, 1/2] spi: Add progress percentage and write speed to `sf update` Simon Glass
2012-12-19 20:59 ` Tom Rini
2012-12-19 22:59 ` Tom Rini
2012-12-19 23:14 ` Wolfgang Denk
2012-12-20 1:03 ` Tom Rini
2012-12-20 1:18 ` Simon Glass
2012-12-20 15:04 ` Tom Rini
2012-12-21 8:46 ` Jagan Teki
2012-12-21 18:21 ` Simon Glass
2012-12-21 19:52 ` Wolfgang Denk
2012-12-19 23:10 ` [U-Boot] [PATCH " Wolfgang Denk
2012-12-19 23:20 ` Simon Glass
2012-12-19 23:42 ` Scott Wood
2012-12-20 6:20 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121219204328.GD14589@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox