From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Wed, 19 Dec 2012 13:43:28 -0700 Subject: [U-Boot] [U-Boot, 1/2] spi: Add progress percentage and write speed to `sf update` In-Reply-To: <1348878482-1730-1-git-send-email-sjg@chromium.org> References: <1348878482-1730-1-git-send-email-sjg@chromium.org> Message-ID: <20121219204328.GD14589@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Fri, Sep 28, 2012 at 02:28:00PM -0000, Simon Glass wrote: > From: James Miller > > Output a progress update only at most 10 times per second, to avoid > saturating (and waiting on) the console. Make the summary line > to fit on a single line. Make sure that cursor sits at the end of > each update line instead of the beginning. > > Sample output: > > SF: Detected W25Q32 with page size 4 KiB, total 4 MiB > Update SPI > 1331200 bytes written, 2863104 bytes skipped in 21.912s, speed 199728 B/s > > time: 21.919 seconds, 21919 ticks > Skipping verify > > Signed-off-by: Simon Glass > Signed-off-by: James Miller > Signed-off-by: Taylor Hutt With ELDK 4.2: cmd_sf.c:80: warning: type qualifiers ignored on function return type Unless I'm missing something, this is the right fix: -static const ulong bytes_per_second(unsigned int len, ulong start_ms) +static ulong bytes_per_second(unsigned int len, ulong start_ms) Because no, we aren't returning a const. If that sounds right I'll fix inline and add my Signed-off-by. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: