From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot,v2,2/2] spi: Add SPI flash test
Date: Wed, 19 Dec 2012 18:07:16 -0700 [thread overview]
Message-ID: <20121220010716.GK14589@bill-the-cat> (raw)
In-Reply-To: <20121219231924.B9F04202B12@gemini.denx.de>
On Thu, Dec 20, 2012 at 12:19:24AM +0100, Wolfgang Denk wrote:
> Dear Tom Rini,
>
> In message <20121219225956.GG14589@bill-the-cat> you wrote:
> >
> > Applied to u-boot/master, thanks!
>
> Please see my comment from a few minutes ago.
>
> We're adding just dead code here. This makes no sense to me.
I'll add this option to am335x_evm as soon as I can sneak over to the
office, flip the dip switches so that the SPI flash is available and
double check that yes, really, Simon tested the code one point before
posting. Yeah, -1 to me for adding this before we added a board using
it, but it's a useful thing. Q/A folks here at least will be all 'oh
boy!' when I tell them that starting with the next release they can use
this.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20121219/0e6cac7c/attachment.pgp>
next prev parent reply other threads:[~2012-12-20 1:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-08 23:16 [U-Boot] [PATCH v2 2/2] spi: Add SPI flash test Simon Glass
2012-12-19 22:59 ` [U-Boot] [U-Boot,v2,2/2] " Tom Rini
2012-12-19 23:19 ` Wolfgang Denk
2012-12-20 1:07 ` Tom Rini [this message]
2012-12-26 20:01 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121220010716.GK14589@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox