From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, 1/2] spi: Add progress percentage and write speed to `sf update`
Date: Thu, 20 Dec 2012 08:04:08 -0700 [thread overview]
Message-ID: <20121220150408.GN14589@bill-the-cat> (raw)
In-Reply-To: <CAPnjgZ2pETu-w7w8QYv2YuKXdrZeHVPYxbMKet6NyYZ8U29uOw@mail.gmail.com>
On Wed, Dec 19, 2012 at 05:18:55PM -0800, Simon Glass wrote:
> Hi Tom,
>
> On Wed, Dec 19, 2012 at 5:03 PM, Tom Rini <trini@ti.com> wrote:
> > On Thu, Dec 20, 2012 at 12:14:00AM +0100, Wolfgang Denk wrote:
> >> Dear Tom Rini,
> >>
> >> In message <20121219225945.GF14589@bill-the-cat> you wrote:
> >> >
> >> ...
> >> > With this change, applied to u-boot/master.
> >>
> >> Argh.... :-(
> >>
> >> Can we please undo this somehow? This does not fit at all
> >> conceptually. U-Boot is supposed to use the good ols UNIX philosophy
> >> of being terse by default, and special casing one specific storage
> >> device makes no sense at all to me.
> >
> > We need to fix some of the underlying problems so that we're consistent
> > here. Sometimes we have output (network #), sometimes we don't.
> > Sometimes we have a speed (network, filesystem load), sometimes we
> > don't. I'd be quite happy to have a uniform output and a uniform ON/OFF
> > switch.
>
> I'm happy to do something like this. Obviously we want a config, but
> do we also want an env variable to control it? Could be useful.
The biggest blocker I see is that we should start the series by
re-orging things, if we can, so that we don't have this code in N
places.
> And at the risk of killing it with feature creep, perhaps we could
> have two levels of verbosity: progress (which repeatedly updates on
> the same line) and notice (which does not). That might take care of
> Jagannadha's use case also.
If we can do it such that it's (a) clean looking and (b) build-time
configurable too, I don't see why we can't give it a look at least.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20121220/131a8724/attachment.pgp>
next prev parent reply other threads:[~2012-12-20 15:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-29 0:28 [U-Boot] [PATCH 1/2] spi: Add progress percentage and write speed to `sf update` Simon Glass
2012-09-29 0:28 ` [U-Boot] [PATCH 2/2] spi: Add SPI flash test Simon Glass
2012-10-01 17:32 ` Tom Rini
2012-10-08 23:00 ` Simon Glass
2012-10-08 23:03 ` Tom Rini
2012-12-19 23:12 ` Wolfgang Denk
2012-12-19 20:43 ` [U-Boot] [U-Boot, 1/2] spi: Add progress percentage and write speed to `sf update` Tom Rini
2012-12-19 20:46 ` Simon Glass
2012-12-19 20:59 ` Tom Rini
2012-12-19 22:59 ` Tom Rini
2012-12-19 23:14 ` Wolfgang Denk
2012-12-20 1:03 ` Tom Rini
2012-12-20 1:18 ` Simon Glass
2012-12-20 15:04 ` Tom Rini [this message]
2012-12-21 8:46 ` Jagan Teki
2012-12-21 18:21 ` Simon Glass
2012-12-21 19:52 ` Wolfgang Denk
2012-12-19 23:10 ` [U-Boot] [PATCH " Wolfgang Denk
2012-12-19 23:20 ` Simon Glass
2012-12-19 23:42 ` Scott Wood
2012-12-20 6:20 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121220150408.GN14589@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox