From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm/bootstage: Move the bootstage call after gd init
Date: Thu, 27 Dec 2012 10:41:06 +0100 [thread overview]
Message-ID: <20121227104106.392a328d@lilith> (raw)
In-Reply-To: <CAPnjgZ2vjRLP9mqnmpkB1uXaiA3i0t4GrEm10ZfdEC0hfyVbxg@mail.gmail.com>
Hi Simon,
On Wed, 26 Dec 2012 12:39:32 -0800, Simon Glass <sjg@chromium.org>
wrote:
> Hi Vikram,
>
> On Sun, Dec 23, 2012 at 3:27 AM, Vikram Narayanan <vikram186@gmail.com> wrote:
> > bootstage_mark_name calls timer_get_boot_us which inturn calls
> > the arch timer. The arch timer uses the gd pointer to save the
> > lastinc count. A call to bootstage_mark_name here results in a
> > data abort as gd is uninitialized.
> >
> > Signed-off-by: Vikram Narayanan <vikram186@gmail.com>
> > Cc: Simon Glass <sjg@chromium.org>
> > Cc: Wolfgang Denk <wd@denx.de>
> > Cc: Albert Aribaud <albert.u.boot@aribaud.net>
>
> Acked-by: Simon Glass <sjg@chromium.org>
>
> This bug will affect boards which don't have their own
> timer_get_boot_us() function.
>
> Albert, I think we should try to get this in as a bug fix in the
> upcoming release.
>
> Thanks for the fix Vikram.
Thanks Vikram and Simon; I'll pull this in today.
Amicalement,
--
Albert.
next prev parent reply other threads:[~2012-12-27 9:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-23 11:27 [U-Boot] [PATCH] arm/bootstage: Move the bootstage call after gd init Vikram Narayanan
2012-12-26 20:39 ` Simon Glass
2012-12-27 9:41 ` Albert ARIBAUD [this message]
2012-12-27 10:22 ` Albert ARIBAUD
2012-12-27 12:51 ` Vikram Narayanan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121227104106.392a328d@lilith \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox