public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC]: always relocate u-boot before the framebuffer
Date: Mon, 31 Dec 2012 15:54:25 +0100	[thread overview]
Message-ID: <20121231145425.DB5CF20051B@gemini.denx.de> (raw)
In-Reply-To: <20121231153353.2d9a5dda@amdc308.digital.local>

Dear Lukasz Majewski,

In message <20121231153353.2d9a5dda@amdc308.digital.local> you wrote:
> 
> > -       addr = lcd_setmem(addr);
> > -       gd->fb_base = addr;
> > +       gd->fb_base = lcd_setmem(addr);
> >  #endif /* CONFIG_FB_ADDR */
> > +       /* always continue placement below the frame buffer to not
> > overlap */
> 
> Good idea. I will test it and let you know. 

Please see my responses.  This is definitely NOT a good idea, it will
break most (all?) boards that use CONFIG_FB_ADDR in the way it was
intended for.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You go slow, be gentle. It's no one-way street -- you  know  how  you
feel and that's all. It's how the girl feels too. Don't press. If the
girl feels anything for you at all, you'll know.
	-- Kirk, "Charlie X", stardate 1535.8

  reply	other threads:[~2012-12-31 14:54 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-29 19:31 [U-Boot] [RFC]: always relocate u-boot before the framebuffer Jeroen Hofstee
2012-12-29 20:10 ` Jeroen Hofstee
2012-12-29 21:50   ` Wolfgang Denk
2012-12-29 21:47 ` Wolfgang Denk
2012-12-31 14:33 ` Lukasz Majewski
2012-12-31 14:54   ` Wolfgang Denk [this message]
2013-01-02 15:48     ` Tom Rini
2013-01-02 20:17       ` Wolfgang Denk
2013-01-03 10:27         ` Jeroen Hofstee
2013-01-03 10:41           ` Wolfgang Denk
2013-01-03 18:10             ` Jeroen Hofstee
2013-01-03 20:28               ` Wolfgang Denk
2013-01-04 20:29                 ` Jeroen Hofstee
2013-01-05 10:07                 ` Jeroen Hofstee
2013-01-05 19:18                   ` Wolfgang Denk
2013-01-03 10:43         ` [U-Boot] [PATCH v2] VIDEO: better document the correct use of CONFIG_FB_ADDR Wolfgang Denk
2013-01-14 19:29           ` Anatolij Gustschin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121231145425.DB5CF20051B@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox