From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Mon, 31 Dec 2012 15:54:25 +0100 Subject: [U-Boot] [RFC]: always relocate u-boot before the framebuffer In-Reply-To: <20121231153353.2d9a5dda@amdc308.digital.local> References: <20121229203157.0f50ba5e@black> <20121231153353.2d9a5dda@amdc308.digital.local> Message-ID: <20121231145425.DB5CF20051B@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Lukasz Majewski, In message <20121231153353.2d9a5dda@amdc308.digital.local> you wrote: > > > - addr = lcd_setmem(addr); > > - gd->fb_base = addr; > > + gd->fb_base = lcd_setmem(addr); > > #endif /* CONFIG_FB_ADDR */ > > + /* always continue placement below the frame buffer to not > > overlap */ > > Good idea. I will test it and let you know. Please see my responses. This is definitely NOT a good idea, it will break most (all?) boards that use CONFIG_FB_ADDR in the way it was intended for. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de You go slow, be gentle. It's no one-way street -- you know how you feel and that's all. It's how the girl feels too. Don't press. If the girl feels anything for you at all, you'll know. -- Kirk, "Charlie X", stardate 1535.8