From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Sat, 5 Jan 2013 09:11:54 +0100
Subject: [U-Boot] [RFC PATCH 13/44] image: Move error! string to common
	place
In-Reply-To: <1357350734-13737-14-git-send-email-sjg@chromium.org>
References: <1357350734-13737-1-git-send-email-sjg@chromium.org>
	<1357350734-13737-14-git-send-email-sjg@chromium.org>
Message-ID: <201301050911.55007.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Simon Glass,

> The string " error\n" appears in each error string. Move it out to a
> common place.
> 
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>  common/image-fit.c |   16 ++++++++--------
>  1 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/common/image-fit.c b/common/image-fit.c
> index 4a78a5c..19942e2 100644
> --- a/common/image-fit.c
> +++ b/common/image-fit.c
> @@ -867,7 +867,7 @@ static int fit_image_check_hash(const void *fit, int
> noffset, const void *data, *err_msgp = NULL;
> 
>  	if (fit_image_hash_get_algo(fit, noffset, &algo)) {
> -		*err_msgp = " error!\nCan't get hash algo "
> +		*err_msgp = "Can't get hash algo "
>  				"property";

Maybe you can fix how the strings are broken here and all around in half now? 
Otherwise

Reviewed-by: Marek Vasut <marex@denx.de>

Best regards,
Marek Vasut