From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Sat, 5 Jan 2013 09:19:01 +0100
Subject: [U-Boot] [RFC PATCH 32/44] image: Support signing of images
In-Reply-To: <1357350734-13737-33-git-send-email-sjg@chromium.org>
References: <1357350734-13737-1-git-send-email-sjg@chromium.org>
	<1357350734-13737-33-git-send-email-sjg@chromium.org>
Message-ID: <201301050919.01629.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Simon Glass,

[...]

> +	int string_size;
> +	int ret;
> +
> +	/*
> +	 * Get the current string size, before we update the FIT and add
> +	 * more
> +	 */
> +	string_size = fdt_size_dt_strings(fit);
> +
> +	ret = fdt_setprop(fit, noffset, FIT_VALUE_PROP, value, value_len);
> +	ret |= fdt_setprop_string(fit, noffset, "signer-name", "mkimage");
> +	ret |= fdt_setprop_string(fit, noffset, "signer-version",
> +				  PLAIN_VERSION);

Can you really be ORR'ing a signed variable such as "ret" ?
[...]
Best regards,
Marek Vasut