From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] common/lcd.c: cleanup use of global variables
Date: Sat, 05 Jan 2013 20:50:01 +0100 [thread overview]
Message-ID: <20130105195001.773F320078F@gemini.denx.de> (raw)
In-Reply-To: <1357415148-9243-1-git-send-email-wd@denx.de>
Dear Anatolij,
In message <1357415148-9243-1-git-send-email-wd@denx.de> you wrote:
> lcd_color_fg and lcd_color_bg had to be declared in board specific
> code, but were not actually used there; in addition, we have getter /
> setter functions for these, which were not used either.
>
> Get rid of the global variables, and use the getter function where
> needed (so far no setter calls are needed).
A similar change could (and probably should?) be implemented for
lcd_base, too - but thjis requires a little more code changes, plus
the introduction of both getter and setter functions.
Do you think this should be done? If so, I would prepare a patch...
[Otherwise I'd save the effort...]
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Motto of the Electrical Engineer: Working computer hardware is a lot
like an erect penis: it stays up as long as you don't fuck with it.
next prev parent reply other threads:[~2013-01-05 19:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-05 18:16 [U-Boot] global variables from comon/lcd.c Jeroen Hofstee
2013-01-05 19:40 ` Wolfgang Denk
2013-01-05 19:45 ` [U-Boot] [PATCH] common/lcd.c: cleanup use of global variables Wolfgang Denk
2013-01-05 19:50 ` Wolfgang Denk [this message]
2013-01-06 22:43 ` Jeroen Hofstee
2013-01-12 17:07 ` Simon Glass
2013-01-06 23:33 ` Anatolij Gustschin
2013-01-12 17:06 ` Simon Glass
2013-01-25 21:26 ` Jeroen Hofstee
2013-03-29 10:56 ` Anatolij Gustschin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130105195001.773F320078F@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox