* [U-Boot] [PATCH] arm:exynos4:pinmux: Modify the gpio function for mmc
@ 2013-01-03 7:30 Piotr Wilczek
2013-01-03 7:31 ` Piotr Wilczek
0 siblings, 1 reply; 8+ messages in thread
From: Piotr Wilczek @ 2013-01-03 7:30 UTC (permalink / raw)
To: u-boot
This patch add pinmux settings for Exynos4 for mmc0 and mmc2
The pinmux setting previously added in commit a3eab2ac41
has been deleted in merge 96764df1b4
Piotr Wilczek (1):
arm:exynos4:pinmux: Modify the gpio function for mmc
arch/arm/cpu/armv7/exynos/pinmux.c | 45 ++++++++++++++++++++++++++++++++++++
1 file changed, 45 insertions(+)
--
1.7.9.5
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] arm:exynos4:pinmux: Modify the gpio function for mmc
2013-01-03 7:30 [U-Boot] [PATCH] arm:exynos4:pinmux: Modify the gpio function for mmc Piotr Wilczek
@ 2013-01-03 7:31 ` Piotr Wilczek
2013-01-03 10:55 ` Jaehoon Chung
2013-01-08 1:50 ` Minkyu Kang
0 siblings, 2 replies; 8+ messages in thread
From: Piotr Wilczek @ 2013-01-03 7:31 UTC (permalink / raw)
To: u-boot
This patch add pinmux settings for Exynos4 for mmc0 and mmc2
Signed-off-by: Piotr Wilczek <p.wilczek@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
CC: Minkyu Kang <mk7.kang@samsung.com>
CC: Albert ARIBAUD <albert.u.boot@aribaud.net>
---
arch/arm/cpu/armv7/exynos/pinmux.c | 45 ++++++++++++++++++++++++++++++++++++
1 file changed, 45 insertions(+)
diff --git a/arch/arm/cpu/armv7/exynos/pinmux.c b/arch/arm/cpu/armv7/exynos/pinmux.c
index 20a4b84..ee58dac 100644
--- a/arch/arm/cpu/armv7/exynos/pinmux.c
+++ b/arch/arm/cpu/armv7/exynos/pinmux.c
@@ -370,6 +370,43 @@ static void exynos4_i2c_config(int peripheral, int flags)
}
}
+static int exynos4_mmc_config(int peripheral, int flags)
+{
+ struct exynos4_gpio_part2 *gpio2 =
+ (struct exynos4_gpio_part2 *)samsung_get_base_gpio_part2();
+ struct s5p_gpio_bank *bank, *bank_ext;
+ int i;
+
+ switch (peripheral) {
+ case PERIPH_ID_SDMMC0:
+ bank = &gpio2->k0;
+ bank_ext = &gpio2->k1;
+ break;
+ case PERIPH_ID_SDMMC2:
+ bank = &gpio2->k2;
+ bank_ext = &gpio2->k3;
+ break;
+ default:
+ return -1;
+ }
+ for (i = 0; i < 7; i++) {
+ if (i == 2)
+ continue;
+ s5p_gpio_cfg_pin(bank, i, GPIO_FUNC(0x2));
+ s5p_gpio_set_pull(bank, i, GPIO_PULL_NONE);
+ s5p_gpio_set_drv(bank, i, GPIO_DRV_4X);
+ }
+ if (flags & PINMUX_FLAG_8BIT_MODE) {
+ for (i = 3; i < 7; i++) {
+ s5p_gpio_cfg_pin(bank_ext, i, GPIO_FUNC(0x3));
+ s5p_gpio_set_pull(bank_ext, i, GPIO_PULL_NONE);
+ s5p_gpio_set_drv(bank_ext, i, GPIO_DRV_4X);
+ }
+ }
+
+ return 0;
+}
+
static int exynos4_pinmux_config(int peripheral, int flags)
{
switch (peripheral) {
@@ -383,6 +420,14 @@ static int exynos4_pinmux_config(int peripheral, int flags)
case PERIPH_ID_I2C7:
exynos4_i2c_config(peripheral, flags);
break;
+ case PERIPH_ID_SDMMC0:
+ case PERIPH_ID_SDMMC2:
+ return exynos4_mmc_config(peripheral, flags);
+ case PERIPH_ID_SDMMC1:
+ case PERIPH_ID_SDMMC3:
+ case PERIPH_ID_SDMMC4:
+ printf("SDMMC device %d not implemented\n", peripheral);
+ return -1;
default:
debug("%s: invalid peripheral %d", __func__, peripheral);
return -1;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] arm:exynos4:pinmux: Modify the gpio function for mmc
2013-01-03 7:31 ` Piotr Wilczek
@ 2013-01-03 10:55 ` Jaehoon Chung
2013-01-04 7:59 ` Lukasz Majewski
2013-01-08 1:50 ` Minkyu Kang
1 sibling, 1 reply; 8+ messages in thread
From: Jaehoon Chung @ 2013-01-03 10:55 UTC (permalink / raw)
To: u-boot
Hi Piotr,
On 01/03/2013 04:31 PM, Piotr Wilczek wrote:
> This patch add pinmux settings for Exynos4 for mmc0 and mmc2
Didn't consider about the mmc4? I know that exynos4 can be used mmc4 for eMMC.
Best Regards,
Jaehoon Chung
>
> Signed-off-by: Piotr Wilczek <p.wilczek@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> CC: Minkyu Kang <mk7.kang@samsung.com>
> CC: Albert ARIBAUD <albert.u.boot@aribaud.net>
> ---
> arch/arm/cpu/armv7/exynos/pinmux.c | 45 ++++++++++++++++++++++++++++++++++++
> 1 file changed, 45 insertions(+)
>
> diff --git a/arch/arm/cpu/armv7/exynos/pinmux.c b/arch/arm/cpu/armv7/exynos/pinmux.c
> index 20a4b84..ee58dac 100644
> --- a/arch/arm/cpu/armv7/exynos/pinmux.c
> +++ b/arch/arm/cpu/armv7/exynos/pinmux.c
> @@ -370,6 +370,43 @@ static void exynos4_i2c_config(int peripheral, int flags)
> }
> }
>
> +static int exynos4_mmc_config(int peripheral, int flags)
> +{
> + struct exynos4_gpio_part2 *gpio2 =
> + (struct exynos4_gpio_part2 *)samsung_get_base_gpio_part2();
> + struct s5p_gpio_bank *bank, *bank_ext;
> + int i;
> +
> + switch (peripheral) {
> + case PERIPH_ID_SDMMC0:
> + bank = &gpio2->k0;
> + bank_ext = &gpio2->k1;
> + break;
> + case PERIPH_ID_SDMMC2:
> + bank = &gpio2->k2;
> + bank_ext = &gpio2->k3;
> + break;
> + default:
> + return -1;
> + }
> + for (i = 0; i < 7; i++) {
> + if (i == 2)
> + continue;
> + s5p_gpio_cfg_pin(bank, i, GPIO_FUNC(0x2));
> + s5p_gpio_set_pull(bank, i, GPIO_PULL_NONE);
> + s5p_gpio_set_drv(bank, i, GPIO_DRV_4X);
> + }
> + if (flags & PINMUX_FLAG_8BIT_MODE) {
> + for (i = 3; i < 7; i++) {
> + s5p_gpio_cfg_pin(bank_ext, i, GPIO_FUNC(0x3));
> + s5p_gpio_set_pull(bank_ext, i, GPIO_PULL_NONE);
> + s5p_gpio_set_drv(bank_ext, i, GPIO_DRV_4X);
> + }
> + }
> +
> + return 0;
> +}
> +
> static int exynos4_pinmux_config(int peripheral, int flags)
> {
> switch (peripheral) {
> @@ -383,6 +420,14 @@ static int exynos4_pinmux_config(int peripheral, int flags)
> case PERIPH_ID_I2C7:
> exynos4_i2c_config(peripheral, flags);
> break;
> + case PERIPH_ID_SDMMC0:
> + case PERIPH_ID_SDMMC2:
> + return exynos4_mmc_config(peripheral, flags);
> + case PERIPH_ID_SDMMC1:
> + case PERIPH_ID_SDMMC3:
> + case PERIPH_ID_SDMMC4:
> + printf("SDMMC device %d not implemented\n", peripheral);
> + return -1;
> default:
> debug("%s: invalid peripheral %d", __func__, peripheral);
> return -1;
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] arm:exynos4:pinmux: Modify the gpio function for mmc
2013-01-03 10:55 ` Jaehoon Chung
@ 2013-01-04 7:59 ` Lukasz Majewski
2013-01-07 2:28 ` Jaehoon Chung
0 siblings, 1 reply; 8+ messages in thread
From: Lukasz Majewski @ 2013-01-04 7:59 UTC (permalink / raw)
To: u-boot
Hi Jaehoon,
> On 01/03/2013 04:31 PM, Piotr Wilczek wrote:
> > This patch add pinmux settings for Exynos4 for mmc0 and mmc2
> Didn't consider about the mmc4? I know that exynos4 can be used mmc4
> for eMMC.
This patch shall be regarded as fixing regression introduced after
merge.
We would like to stick (at least for now) to eMMC cotrollers tied to
mmc0 and mmc2.
When mmc4 (dw_mmc) will be enabled, then surely we will modify the
pinmux code.
--
Best regards,
Lukasz Majewski
Samsung R&D Poland (SRPOL) | Linux Platform Group
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] arm:exynos4:pinmux: Modify the gpio function for mmc
2013-01-04 7:59 ` Lukasz Majewski
@ 2013-01-07 2:28 ` Jaehoon Chung
0 siblings, 0 replies; 8+ messages in thread
From: Jaehoon Chung @ 2013-01-07 2:28 UTC (permalink / raw)
To: u-boot
Hi Lukasz,
I understood your opinion..it's ok.
After applied this patch, i will update the pinmux for MMC4.
Best Regards,
Jaehoon Chung
On 01/04/2013 04:59 PM, Lukasz Majewski wrote:
> Hi Jaehoon,
>
>> On 01/03/2013 04:31 PM, Piotr Wilczek wrote:
>>> This patch add pinmux settings for Exynos4 for mmc0 and mmc2
>> Didn't consider about the mmc4? I know that exynos4 can be used mmc4
>> for eMMC.
>
> This patch shall be regarded as fixing regression introduced after
> merge.
>
> We would like to stick (at least for now) to eMMC cotrollers tied to
> mmc0 and mmc2.
>
> When mmc4 (dw_mmc) will be enabled, then surely we will modify the
> pinmux code.
>
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] arm:exynos4:pinmux: Modify the gpio function for mmc
2013-01-03 7:31 ` Piotr Wilczek
2013-01-03 10:55 ` Jaehoon Chung
@ 2013-01-08 1:50 ` Minkyu Kang
2013-01-08 14:03 ` Albert ARIBAUD
1 sibling, 1 reply; 8+ messages in thread
From: Minkyu Kang @ 2013-01-08 1:50 UTC (permalink / raw)
To: u-boot
On 03/01/13 16:31, Piotr Wilczek wrote:
> This patch add pinmux settings for Exynos4 for mmc0 and mmc2
>
> Signed-off-by: Piotr Wilczek <p.wilczek@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> CC: Minkyu Kang <mk7.kang@samsung.com>
> CC: Albert ARIBAUD <albert.u.boot@aribaud.net>
> ---
> arch/arm/cpu/armv7/exynos/pinmux.c | 45 ++++++++++++++++++++++++++++++++++++
> 1 file changed, 45 insertions(+)
>
applied to u-boot-samsung.
Thanks,
Minkyu Kang.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] arm:exynos4:pinmux: Modify the gpio function for mmc
2013-01-08 1:50 ` Minkyu Kang
@ 2013-01-08 14:03 ` Albert ARIBAUD
2013-01-09 1:22 ` Minkyu Kang
0 siblings, 1 reply; 8+ messages in thread
From: Albert ARIBAUD @ 2013-01-08 14:03 UTC (permalink / raw)
To: u-boot
Hi Minkyu,
On Tue, 08 Jan 2013 10:50:58 +0900, Minkyu Kang <mk7.kang@samsung.com>
wrote:
> On 03/01/13 16:31, Piotr Wilczek wrote:
> > This patch add pinmux settings for Exynos4 for mmc0 and mmc2
> >
> > Signed-off-by: Piotr Wilczek <p.wilczek@samsung.com>
> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> > CC: Minkyu Kang <mk7.kang@samsung.com>
> > CC: Albert ARIBAUD <albert.u.boot@aribaud.net>
> > ---
> > arch/arm/cpu/armv7/exynos/pinmux.c | 45 ++++++++++++++++++++++++++++++++++++
> > 1 file changed, 45 insertions(+)
> >
>
> applied to u-boot-samsung.
So I guess you'll be sending out a pull request for the Samung tree
soon, right?
> Thanks,
> Minkyu Kang.
Amicalement,
--
Albert.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] arm:exynos4:pinmux: Modify the gpio function for mmc
2013-01-08 14:03 ` Albert ARIBAUD
@ 2013-01-09 1:22 ` Minkyu Kang
0 siblings, 0 replies; 8+ messages in thread
From: Minkyu Kang @ 2013-01-09 1:22 UTC (permalink / raw)
To: u-boot
On 08/01/13 23:03, Albert ARIBAUD wrote:
> Hi Minkyu,
>
> On Tue, 08 Jan 2013 10:50:58 +0900, Minkyu Kang <mk7.kang@samsung.com>
> wrote:
>> On 03/01/13 16:31, Piotr Wilczek wrote:
>>> This patch add pinmux settings for Exynos4 for mmc0 and mmc2
>>>
>>> Signed-off-by: Piotr Wilczek <p.wilczek@samsung.com>
>>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>>> CC: Minkyu Kang <mk7.kang@samsung.com>
>>> CC: Albert ARIBAUD <albert.u.boot@aribaud.net>
>>> ---
>>> arch/arm/cpu/armv7/exynos/pinmux.c | 45 ++++++++++++++++++++++++++++++++++++
>>> 1 file changed, 45 insertions(+)
>>>
>>
>> applied to u-boot-samsung.
>
> So I guess you'll be sending out a pull request for the Samung tree
> soon, right?
>
Yes, will send soon.
Thanks.
Minkyu Kang.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2013-01-09 1:22 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-03 7:30 [U-Boot] [PATCH] arm:exynos4:pinmux: Modify the gpio function for mmc Piotr Wilczek
2013-01-03 7:31 ` Piotr Wilczek
2013-01-03 10:55 ` Jaehoon Chung
2013-01-04 7:59 ` Lukasz Majewski
2013-01-07 2:28 ` Jaehoon Chung
2013-01-08 1:50 ` Minkyu Kang
2013-01-08 14:03 ` Albert ARIBAUD
2013-01-09 1:22 ` Minkyu Kang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).