From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Tue, 8 Jan 2013 20:50:23 +0100 Subject: [U-Boot] [PATCH v4 1/2] arm: move C runtime setup code in crt0.S In-Reply-To: <20130108192607.GA10015@bill-the-cat> References: <1352566813-30386-1-git-send-email-albert.u.boot@aribaud.net> <1354020206-24762-1-git-send-email-albert.u.boot@aribaud.net> <1354020206-24762-2-git-send-email-albert.u.boot@aribaud.net> <20130108192607.GA10015@bill-the-cat> Message-ID: <20130108205023.672e84cf@lilith> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Tom, On Tue, 8 Jan 2013 12:26:07 -0700, Tom Rini wrote: > On Tue, Nov 27, 2012 at 01:43:25PM +0100, Albert ARIBAUD wrote: > > > Move all the C runtime setup code from every start.S > > in arch/arm into arch/arm/lib/crt0.S. This covers > > the code sequence from setting up the initial stack > > to calling into board_init_r(). > > > > Also, rewrite the C runtime setup and make functions > > board_init_*() and relocate_code() behave according to > > normal C semantics (no jumping across the C stack any > > more, etc). > > > > Some SPL targets had to be touched because they use > > start.S explicitly or for some reason; the relevant > > maintainers and custodians are cc:ed. > > > > Signed-off-by: Albert ARIBAUD > > --- > > Changes in v4: > > - fixed bhs into blo in BSS init loop > > - switched from explicit literals to '=target' notation > > - fixed location of GD in initial environment > > - stopped SPL boot sequence at calling board_init_f > > > > Changes in v3: > > - various clarifications and typo fixes > > - fixed wrong LED calls conditional > > - fixed open comment eating some code > > - fixed code overrun in SPL case > > > > Changes in v2: > > - moved description from cover letter to patch commit msg > > - added note about tests in the cover letter > > - fixed baords with CONFIG_SPL but not CONFIG_SPL_STACK > > This change breaks sandbox, powerpc, mips and m68k. I suspect fixing > sandbox will be the easiest test-case and catch all of the others. > > -- > Tom Ok, then, rolling back ARM and pushing v5 to fix breakage on non-ARM arches. Amicalement, -- Albert.