From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2] fs: fat: Fix mkcksum() function parameters
Date: Wed, 9 Jan 2013 10:14:38 +0100 [thread overview]
Message-ID: <201301091014.38472.marex@denx.de> (raw)
In-Reply-To: <50ECCDE1.2020707@cavium.com>
Dear Aaron Williams,
> Hi Marek,
>
> This patch is broken. It breaks detecting duplicate filenames. The
> problem is that you are using sizeof(name) and sizeof(ext). This does
> not work since this just reports the size of the pointer in gcc 4.7,
> which according to our compiler guy is the correct behavior. Instead of
> using sizeof, just use 8 and 3 respectively. Otherwise it is doing a
> checksum of 4 and 4 characters.
You're right. Can you post a patch for that please? This was already applied.
Also, do you see any symptoms?
Best regards,
Marek Vasut
prev parent reply other threads:[~2013-01-09 9:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-30 0:49 [U-Boot] [PATCH] fs: fat: Fix mkcksum() function parameters Marek Vasut
2012-10-09 16:45 ` Tom Rini
2012-10-09 17:20 ` [U-Boot] [PATCH V2] " Marek Vasut
2012-10-17 15:03 ` [U-Boot] [U-Boot, " Tom Rini
2013-01-09 1:54 ` [U-Boot] [PATCH " Aaron Williams
2013-01-09 9:14 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201301091014.38472.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox