From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Wed, 9 Jan 2013 10:14:38 +0100 Subject: [U-Boot] [PATCH V2] fs: fat: Fix mkcksum() function parameters In-Reply-To: <50ECCDE1.2020707@cavium.com> References: <1348966149-15658-1-git-send-email-marex@denx.de> <1349803222-15917-1-git-send-email-marex@denx.de> <50ECCDE1.2020707@cavium.com> Message-ID: <201301091014.38472.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Aaron Williams, > Hi Marek, > > This patch is broken. It breaks detecting duplicate filenames. The > problem is that you are using sizeof(name) and sizeof(ext). This does > not work since this just reports the size of the pointer in gcc 4.7, > which according to our compiler guy is the correct behavior. Instead of > using sizeof, just use 8 and 3 respectively. Otherwise it is doing a > checksum of 4 and 4 characters. You're right. Can you post a patch for that please? This was already applied. Also, do you see any symptoms? Best regards, Marek Vasut