[U-Boot] [PATCH] MPC8308: Fixup clocks in PCI Host configuration

[Wolfgang Denk <wd@denx.de>]

Dear Barry Grussling,

In message <1357669446-29334-1-git-send-email-barry@grussling.com> you wrote:
> While trying to bring up a custom MPC8308 based board I found
> that the clocking was wrong.  The comment in
> include/configs/mpc8308_p1m.h led me to believe
> setting HRCWH_PCI_HOST and HRCWH_PCI1_ARBITER_ENABLE in the
> CONFIG_SYS_HRCW_HIGH should allow the system to work, but on
> my newer version of the 8308 this is not working.  Setting
> the HRCWH_PCI_HOST bit (which doesn't exist according to the manual)
> doesn't latch, and as such the im->reset.rcwh & HRCWH_PCI_HOST test
> in speed.c fails.  Since this board is running off the
> CONFIG_83XX_CLKIN and is not a PCI client, I end up with 0xdeadbeef
> and hosed clock values.
> 
> This patch allows for proper clocks on the 8308 as a workaround
> for the lack of HRCWH_PCI_HOST support.

You say this patchis working on "your newer version of the 8308".  Can
you please be specific what "old" and "new" actually means here?

And has this patch been tested to also work on the "old" versions of
the 8308?


> +#elif defined(CONFIG_83XX_CLKIN) && defined(CONFIG_MPC8308)
> +	/* 8308 doesn't have the HRCWH_PCI_HOST, but should 
> +	 * run off the CONFIG_83XX_CLKIN */

Incorrect multiline comment style.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"May your future be limited only by your dreams."
- Christa McAuliffe