From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Thu, 10 Jan 2013 08:14:04 -0700 Subject: [U-Boot] [PATCH 2/2] pcm051: Add support for Phytec phyCORE-AM335x In-Reply-To: <0E39AF7C-22FB-47F7-8639-6FD4CDAD6C43@lemonage.de> References: <1357663926-15937-1-git-send-email-larsi@wh2.tu-dresden.de> <1357663926-15937-2-git-send-email-larsi@wh2.tu-dresden.de> <20130108185837.577D3202B69@gemini.denx.de> <20130109193416.GA5802@bill-the-cat> <0E39AF7C-22FB-47F7-8639-6FD4CDAD6C43@lemonage.de> Message-ID: <20130110151404.GA12136@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, Jan 10, 2013 at 08:30:09AM +0100, Lars Poeschel wrote: > Hi Wolfgang, hi Tom, > > as I almost have the changes requested by Wolfgang in place, you two can choose, which version I should resubmit. ;) > > Am 09.01.2013 um 20:34 schrieb Tom Rini: [snip] > >>> + if (!eth_getenv_enetaddr("ethaddr", mac_addr)) { > >>> + debug(" not set. Reading from E-fuse\n"); > >> > >> This should be a printf(). Any such automatic changes are always > >> worth to be told explicitly. > > > > This is the normal case of asking the hardware what MAC it shipped with. > > Why do we want to tell the user the expected has happened? > > Here I'd prefer the printf variant, because for a common user it is not obivous, that it is reading the MAC from efuse. So this message is helpful. OK, please also patch board/ti/am335x/board.c to also printf here then. Other than that, yes, I'd be happy to see you make the other changes you said. Just partially trying to help explain the SoC to Wolfgang :) -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: