From mboxrd@z Thu Jan  1 00:00:00 1970
From: Allen Martin <amartin@nvidia.com>
Date: Fri, 11 Jan 2013 19:42:25 -0800
Subject: [U-Boot] [PATCH 4/7] tegra30: fdt: add SPI SLINK nodes
In-Reply-To: <50F0AB8E.1040205@wwwdotorg.org>
References: <1357929877-18671-1-git-send-email-amartin@nvidia.com>
	<1357929877-18671-5-git-send-email-amartin@nvidia.com>
	<50F0AB8E.1040205@wwwdotorg.org>
Message-ID: <20130112034225.GC27011@badger>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Fri, Jan 11, 2013 at 04:17:18PM -0800, Stephen Warren wrote:
> On 01/11/2013 11:44 AM, Allen Martin wrote:
> > Add tegra30 SPI SLINK nodes to fdt.
> 
> > diff --git a/arch/arm/dts/tegra30.dtsi b/arch/arm/dts/tegra30.dtsi
> 
> >  		/* PERIPH_ID_I2C_DVC, CLK_M */
> >  		clocks = <&tegra_car 47>;
> >  	};
> > +	spi at 7000d400 {
> 
> Blank line needed before the new node.

ok

> 
> > +		compatible = "nvidia,tegra30-slink", "nvidia,tegra20-slink";
> > +		reg = <0x7000d400 0x200>;
> 
> I can't tell if the sort order is correct here; not enough context in
> the diff.

It's not, I'll fix.

> 
> > +		interrupts = <0 59 0x04>;
> > +		nvidia,dma-request-selector = <&apbdma 15>;
> > +		spi-max-frequency = <25000000>;
> 
> Same comment about that property being board-specific.

ok

> 
> > +		#address-cells = <1>;
> > +		#size-cells = <0>;
> > +		status = "disabled";
> > +		/* PERIPH_ID_SBC1, PLLP_OUT0 */
> > +		clocks = <&tegra_car 41>;
> > +	};
> 

-Allen
-- 
nvpublic