From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 16/18 V2] mxs: Add MX23 olinuxino board support
Date: Sat, 12 Jan 2013 17:52:16 +0100 [thread overview]
Message-ID: <201301121752.16829.marex@denx.de> (raw)
In-Reply-To: <CAP9ODKpfaxiDyr8uwci0u2sYM9DsWg2Xbjheo8Ughgae-o46RQ@mail.gmail.com>
Dear Otavio Salvador,
> On Sat, Jan 12, 2013 at 2:16 PM, Marek Vasut <marex@denx.de> wrote:
> > Dear Otavio Salvador,
> >
> >> On Fri, Jan 11, 2013 at 9:27 PM, Marek Vasut <marex@denx.de> wrote:
> >> > This patch adds support for MX23-based Olinuxino board.
> >> >
> >> > Signed-off-by: Marek Vasut <marex@denx.de>
> >> > Cc: Fabio Estevam <fabio.estevam@freescale.com>
> >> > Cc: Otavio Salvador <otavio@ossystems.com.br>
> >> > Cc: Stefano Babic <sbabic@denx.de>
> >> > ---
> >> >
> >> > MAINTAINERS | 1 +
> >> > board/olimex/mx23_olinuxino/Makefile | 47 +++++++++
> >> > board/olimex/mx23_olinuxino/mx23_olinuxino.c | 51 ++++++++++
> >> > board/olimex/mx23_olinuxino/spl_boot.c | 90 +++++++++++++++++
> >> > boards.cfg | 1 +
> >> > include/configs/mx23_olinuxino.h | 133
> >> > ++++++++++++++++++++++++++ 6 files changed, 323 insertions(+)
> >> > create mode 100644 board/olimex/mx23_olinuxino/Makefile
> >> > create mode 100644 board/olimex/mx23_olinuxino/mx23_olinuxino.c
> >> > create mode 100644 board/olimex/mx23_olinuxino/spl_boot.c
> >> > create mode 100644 include/configs/mx23_olinuxino.h
> >> >
> >> > V2: Add MAINTAINERS entry
> >> >
> >> > Remove CONFIG_MACH_TYPE (as this board is DT-only)
> >>
> >> In fact it is not DT-only; we support it in linux-imx inside of OE and
> >> the images provided by Olinex are also based 2.6.35 so it seems better
> >> to define the machine type.
> >
> > Can be added in a subsequent patch.
> > [...]
>
> I don't think it is the way to go for several reasons, mainly:
>
> * your v1 had this support
0xffffffff is DT boot ID really.
> * all sdcards provided by olimex use 2.6.35 kernel (until now)
> * the FSL supported kernel is non-DT
>
> So I see no reason to not fix the patch, seriously.
Can you provide pointer to olinuxino machine entry in RMK's ID database then
please?
> >> > +/*
> >> > + * U-Boot general configurations
> >> > + */
> >> > +#define CONFIG_SYS_LONGHELP
> >> > +#define CONFIG_SYS_PROMPT "=> "
> >> > +#define CONFIG_SYS_CBSIZE 1024 /* Console I/O
> >> > buffer size */
> >>
> >> The SYS_CBSIZE might be smaller I think; we use 256 in sabresd and
> >> others which have a much bigger environment so I think it could be
> >> reduced.
> >
> > Can you elaborate what issues this causes please?
>
> It causes nothing except more memory allocation than need. As other
> bords work fine with less it seems a good option to move to a smaller
> value. Just it.
It reduces the size of console buffer, right?
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-01-12 16:52 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-11 13:19 [U-Boot] [PATCH 01/18] mxs: mmc: Drop unused members from struct mxsmmc_priv Marek Vasut
2013-01-11 13:19 ` [U-Boot] [PATCH 02/18] mxs: ssp: Pull out the SSP bus to regs conversion Marek Vasut
2013-01-11 13:19 ` [U-Boot] [PATCH 03/18] mxs: clock: Use 'mxs' prefix for methods Marek Vasut
2013-01-11 13:19 ` [U-Boot] [PATCH 04/18] mx23: Add register base addresses Marek Vasut
2013-01-11 13:19 ` [U-Boot] [PATCH 05/18] mx23: Add iomux-mx23.h Marek Vasut
2013-01-11 13:19 ` [U-Boot] [PATCH 06/18] mx23: Add POWER and CLKCTRL register definitions Marek Vasut
2013-01-11 13:19 ` [U-Boot] [PATCH 07/18] mx23: ssp: Fix ssp-regs.h for MX23 Marek Vasut
2013-01-11 13:19 ` [U-Boot] [PATCH 08/18] mx23: Add support on print_cpuinfo() Marek Vasut
2013-01-11 13:19 ` [U-Boot] [PATCH 09/18] mx23: Add boot mode description Marek Vasut
2013-01-11 13:19 ` [U-Boot] [PATCH 10/18] mx23: SPL: Add boot mode support Marek Vasut
2013-01-11 13:19 ` [U-Boot] [PATCH 11/18] mx23: SPL: Initialize DDR at 133MHz Marek Vasut
2013-01-11 13:19 ` [U-Boot] [PATCH 12/18] mx23: config: Enable building of u-boot.sb binary Marek Vasut
2013-01-11 13:19 ` [U-Boot] [PATCH 13/18] mx23: config: Enable mxsboot tool for i.MX23 based boards Marek Vasut
2013-01-11 13:19 ` [U-Boot] [PATCH 14/18] mmc: Limit the number of used SSP ports on MX23 Marek Vasut
2013-01-11 13:19 ` [U-Boot] [PATCH 15/18] mxs: Add MX23 quirks into the clock code Marek Vasut
2013-01-20 2:02 ` [U-Boot] [PATCH 15/18 V2] " Marek Vasut
2013-01-11 13:19 ` [U-Boot] [PATCH 16/18] mxs: Add MX23 olinuxino board support Marek Vasut
2013-01-11 20:58 ` Fabio Estevam
2013-01-11 23:27 ` Marek Vasut
2013-01-12 13:21 ` Otavio Salvador
2013-01-12 16:14 ` Marek Vasut
2013-01-11 23:27 ` [U-Boot] [PATCH 16/18 V2] " Marek Vasut
2013-01-12 13:19 ` Otavio Salvador
2013-01-12 16:16 ` Marek Vasut
2013-01-12 16:39 ` Otavio Salvador
2013-01-12 16:52 ` Marek Vasut [this message]
2013-01-12 17:06 ` Otavio Salvador
2013-01-12 17:11 ` [U-Boot] [PATCH 16/18 V3] " Marek Vasut
2013-01-11 13:19 ` [U-Boot] [PATCH 17/18] mxs: Add function to ungate the power block on MX23 Marek Vasut
2013-01-11 13:19 ` [U-Boot] [PATCH 18/18] mxs: Fix the memory init for MX23 Marek Vasut
2013-01-21 11:11 ` [U-Boot] [PATCH 01/18] mxs: mmc: Drop unused members from struct mxsmmc_priv Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201301121752.16829.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox