From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Sun, 13 Jan 2013 00:53:20 +0100 Subject: [U-Boot] [PATCH 3/3] pxa: Save lr register in relocate_code function In-Reply-To: <1358026767-28130-3-git-send-email-luk0104@gmail.com> References: <1358026767-28130-1-git-send-email-luk0104@gmail.com> <1358026767-28130-3-git-send-email-luk0104@gmail.com> Message-ID: <201301130053.21146.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Lukasz Dalek, > When u-boot is compiled for PXA25x processor, pxa/start.S is calling > cpu_init_crit by BL instruction. BL is overwriting lr register so > relocate_code is going into infinite loop. This patch preservs lr > register in r12 before calling cpu_init_crit and after function returns > restores it. > > Signed-off-by: Lukasz Dalek Acked-by: Marek Vasut Tom/Albert, can you please apply this for .01, seems critical to me ? > --- > arch/arm/cpu/pxa/start.S | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/cpu/pxa/start.S b/arch/arm/cpu/pxa/start.S > index 72af869..e71803e 100644 > --- a/arch/arm/cpu/pxa/start.S > +++ b/arch/arm/cpu/pxa/start.S > @@ -183,7 +183,9 @@ relocate_code: > > /* Disable the Dcache RAM lock for stack now */ > #ifdef CONFIG_CPU_PXA25X > + mov r12, lr > bl cpu_init_crit > + mov lr, r12 > #endif > > adr r0, _start Best regards, Marek Vasut