public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Allen Martin <amartin@nvidia.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [Patch v2] Introduce a global bool type
Date: Fri, 18 Jan 2013 20:58:10 -0800	[thread overview]
Message-ID: <20130119045810.GB19450@badger> (raw)
In-Reply-To: <20130108062928.BA9B1200732@gemini.denx.de>

On Mon, Jan 07, 2013 at 10:29:28PM -0800, Wolfgang Denk wrote:
> Dear York Sun,
> 
> In message <1357602948-16848-1-git-send-email-yorksun@freescale.com> you wrote:
> > 'bool' is defined in random places. This patch consolidates them into a
> > single typedef, using _Bool introduced in C99.
> > 
> > Signed-off-by: York Sun <yorksun@freescale.com>
> > ---
> > Change since v1:
> >  Move 'false' and 'true' to the common header file.
> 
> Please see M?ns Rullg?rd's comment about using stdbool.h instead.
> 

Isn't stdbool.h more for backward compatability for user space
programs, so only newer C99 aware programs can opt-in to the new data
type?  Linux for example doesn't use stdbool.h, it puts the definition
of "bool" in types.h, and true/false in stddef.h.  Since, like Linux,
u-boot is a single codebase, all the data types can go in a common
place and not have to worry about breaking old programs with new
types. 


> Then please make sure that a sufficient number of tool chains as well
> as configurations using USE_PRIVATE_LIBGCC continue to work, i. e. in
> a first step verify that these are still compile-clean.

If you cc me on newer versions of the patch I can help verify on
tegra, which uses USE_PRIVATE_LIBGCC.


-Allen
-- 
nvpublic

  reply	other threads:[~2013-01-19  4:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-07 23:55 [U-Boot] [Patch v2] Introduce a global bool type York Sun
2013-01-08  6:29 ` Wolfgang Denk
2013-01-19  4:58   ` Allen Martin [this message]
2013-01-19  4:47 ` Allen Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130119045810.GB19450@badger \
    --to=amartin@nvidia.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox