From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/9] mx23: Use XFER_COUNT field in HW_SSP_CTRL0 register in MMC PIO mode
Date: Tue, 22 Jan 2013 03:01:14 +0100 [thread overview]
Message-ID: <201301220301.14526.marex@denx.de> (raw)
In-Reply-To: <CAP9ODKoRHA728UYktMzAccJNbP5UYKSmpDLPH+c_u3ToO0QKGQ@mail.gmail.com>
Dear Otavio Salvador,
> On Mon, Jan 21, 2013 at 11:45 PM, Marek Vasut <marex@denx.de> wrote:
> > Dear Otavio Salvador,
> >
> >> From: Marek Vasut <marex@denx.de>
> >>
> >> Signed-off-by: Marek Vasut <marex@denx.de>
> >> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> >> ---
> >>
> >> drivers/mmc/mxsmmc.c | 24 +++++++++++++++++++++---
> >> 1 file changed, 21 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/drivers/mmc/mxsmmc.c b/drivers/mmc/mxsmmc.c
> >> index 0c4cd54..4b178be 100644
> >> --- a/drivers/mmc/mxsmmc.c
> >> +++ b/drivers/mmc/mxsmmc.c
> >> @@ -211,14 +211,32 @@ mxsmmc_send_cmd(struct mmc *mmc, struct mmc_cmd
> >> *cmd, struct mmc_data *data) }
> >>
> >> ctrl0 |= SSP_CTRL0_DATA_XFER;
> >>
> >> +
> >> + reg = data->blocksize * data->blocks;
> >> +#if defined(CONFIG_MX23)
> >> + if (reg & ~SSP_CTRL0_XFER_COUNT_MASK) {
> >> + printf("MMC%d: Transfer too large (%i bytes)!\n",
> >> + mmc->block_dev.dev, reg);
> >> + return -EINVAL;
> >> + }
> >> +
> >> + ctrl0 |= reg & SSP_CTRL0_XFER_COUNT_MASK;
> >> +
> >> + reg = readl(&ssp_regs->hw_ssp_cmd0);
> >> + reg &= ~0xfff00;
> >> + reg |= (data->blocks - 1) << 8;
> >> + reg |= (ffs(data->blocksize) - 1) << 16;
> >
> > This is using some random hard-coded offsets, I told you numerous times I
> > will NAK this.
>
> It is your patch ;-) So ...
So I'll NAK it. I have no problem with it. Besides, this is only based on my
work, but whatever.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-01-22 2:01 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-22 1:47 [U-Boot] [PATCH 0/9] iMX23 MMC support and environment addition Otavio Salvador
2013-01-22 1:47 ` [U-Boot] [PATCH 1/9] mx23: Add SSP registers map Otavio Salvador
2013-01-22 1:47 ` [U-Boot] [PATCH 2/9] mx23: Use XFER_COUNT field in HW_SSP_CTRL0 register in MMC PIO mode Otavio Salvador
2013-01-22 1:45 ` Marek Vasut
2013-01-22 1:53 ` Otavio Salvador
2013-01-22 2:01 ` Marek Vasut [this message]
2013-01-22 1:47 ` [U-Boot] [PATCH 3/9] mx23: Fix transfer size setting for SPI Otavio Salvador
2013-01-22 1:46 ` Marek Vasut
2013-01-22 1:55 ` Otavio Salvador
2013-01-22 2:00 ` Marek Vasut
2013-01-24 18:14 ` Marek Vasut
2013-01-22 1:47 ` [U-Boot] [PATCH 4/9] mx23evk: Add initial board support Otavio Salvador
2013-01-22 1:46 ` Marek Vasut
2013-01-22 2:02 ` Otavio Salvador
2013-01-22 2:16 ` Marek Vasut
2013-01-22 2:30 ` Fabio Estevam
2013-01-22 2:42 ` Marek Vasut
2013-01-22 10:05 ` Otavio Salvador
2013-01-22 1:47 ` [U-Boot] [PATCH 5/9] mx23_olinuxino: Add MMC support Otavio Salvador
2013-01-22 1:47 ` Marek Vasut
2013-01-22 1:58 ` Otavio Salvador
2013-01-22 1:47 ` [U-Boot] [PATCH 6/9] mx23_olinuxino: Skip MMC Card detection Otavio Salvador
2013-01-22 1:48 ` Marek Vasut
2013-01-22 1:58 ` Otavio Salvador
2013-01-22 1:59 ` Marek Vasut
2013-01-22 1:47 ` [U-Boot] [PATCH 7/9] mx23_olinuxino: Add default environment Otavio Salvador
2013-01-22 1:49 ` Marek Vasut
2013-01-22 2:00 ` Otavio Salvador
2013-01-22 2:34 ` Fabio Estevam
2013-01-22 1:47 ` [U-Boot] [PATCH 8/9] mxs: Fix MMC reset to avoid write errors and timeout in iMX23 Otavio Salvador
2013-01-22 1:49 ` Marek Vasut
2013-01-22 2:03 ` Otavio Salvador
2013-01-22 2:15 ` Marek Vasut
2013-01-22 1:47 ` [U-Boot] [PATCH 9/9] mx23: Use PIO mode support for MMC Otavio Salvador
2013-01-22 1:50 ` Marek Vasut
2013-01-22 1:56 ` Otavio Salvador
2013-01-22 1:59 ` Marek Vasut
2013-01-23 9:04 ` Stefano Babic
2013-01-23 11:05 ` Otavio Salvador
2013-01-23 11:26 ` Marek Vasut
2013-01-23 11:39 ` Stefano Babic
2013-01-23 11:48 ` Marek Vasut
2013-01-23 12:12 ` Otavio Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201301220301.14526.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox