From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 8/9] mxs: Fix MMC reset to avoid write errors and timeout in iMX23
Date: Tue, 22 Jan 2013 03:15:34 +0100 [thread overview]
Message-ID: <201301220315.34552.marex@denx.de> (raw)
In-Reply-To: <CAP9ODKrp+=FNOiESFd-qodeVOJAcuLhVdOBjVYv3qDRSX_bvuQ@mail.gmail.com>
Dear Otavio Salvador,
> On Mon, Jan 21, 2013 at 11:49 PM, Marek Vasut <marex@denx.de> wrote:
> > Dear Otavio Salvador,
> >
> >> This does the same reset mask as done in v3.7 Linux kernel code; it
> >> fixed the saveenv command in mx23evk.
> >>
> >> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> >> ---
> >>
> >> drivers/mmc/mxsmmc.c | 16 +++++++++++-----
> >> 1 file changed, 11 insertions(+), 5 deletions(-)
> >>
> >> diff --git a/drivers/mmc/mxsmmc.c b/drivers/mmc/mxsmmc.c
> >> index 618659e..0a3f0c4 100644
> >> --- a/drivers/mmc/mxsmmc.c
> >> +++ b/drivers/mmc/mxsmmc.c
> >> @@ -354,11 +354,17 @@ static int mxsmmc_init(struct mmc *mmc)
> >>
> >> /* Reset SSP */
> >> mxs_reset_block(&ssp_regs->hw_ssp_ctrl0_reg);
> >>
> >> - /* 8 bits word length in MMC mode */
> >> - clrsetbits_le32(&ssp_regs->hw_ssp_ctrl1,
> >> - SSP_CTRL1_SSP_MODE_MASK | SSP_CTRL1_WORD_LENGTH_MASK |
> >> - SSP_CTRL1_DMA_ENABLE,
> >> - SSP_CTRL1_SSP_MODE_SD_MMC |
> >> SSP_CTRL1_WORD_LENGTH_EIGHT_BITS); + /* Reset MMC */
> >> + writel(SSP_CTRL1_SSP_MODE_SD_MMC |
> >> + SSP_CTRL1_WORD_LENGTH_EIGHT_BITS |
> >> + SSP_CTRL1_DMA_ENABLE |
> >> + SSP_CTRL1_POLARITY |
> >
> > Will this addition not break mx28?
>
> Not tested. I hope it does not as it has been taken from v3.7 kernel.
Please, mark all such untested code which can possibly break other platforms in
the description.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-01-22 2:15 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-22 1:47 [U-Boot] [PATCH 0/9] iMX23 MMC support and environment addition Otavio Salvador
2013-01-22 1:47 ` [U-Boot] [PATCH 1/9] mx23: Add SSP registers map Otavio Salvador
2013-01-22 1:47 ` [U-Boot] [PATCH 2/9] mx23: Use XFER_COUNT field in HW_SSP_CTRL0 register in MMC PIO mode Otavio Salvador
2013-01-22 1:45 ` Marek Vasut
2013-01-22 1:53 ` Otavio Salvador
2013-01-22 2:01 ` Marek Vasut
2013-01-22 1:47 ` [U-Boot] [PATCH 3/9] mx23: Fix transfer size setting for SPI Otavio Salvador
2013-01-22 1:46 ` Marek Vasut
2013-01-22 1:55 ` Otavio Salvador
2013-01-22 2:00 ` Marek Vasut
2013-01-24 18:14 ` Marek Vasut
2013-01-22 1:47 ` [U-Boot] [PATCH 4/9] mx23evk: Add initial board support Otavio Salvador
2013-01-22 1:46 ` Marek Vasut
2013-01-22 2:02 ` Otavio Salvador
2013-01-22 2:16 ` Marek Vasut
2013-01-22 2:30 ` Fabio Estevam
2013-01-22 2:42 ` Marek Vasut
2013-01-22 10:05 ` Otavio Salvador
2013-01-22 1:47 ` [U-Boot] [PATCH 5/9] mx23_olinuxino: Add MMC support Otavio Salvador
2013-01-22 1:47 ` Marek Vasut
2013-01-22 1:58 ` Otavio Salvador
2013-01-22 1:47 ` [U-Boot] [PATCH 6/9] mx23_olinuxino: Skip MMC Card detection Otavio Salvador
2013-01-22 1:48 ` Marek Vasut
2013-01-22 1:58 ` Otavio Salvador
2013-01-22 1:59 ` Marek Vasut
2013-01-22 1:47 ` [U-Boot] [PATCH 7/9] mx23_olinuxino: Add default environment Otavio Salvador
2013-01-22 1:49 ` Marek Vasut
2013-01-22 2:00 ` Otavio Salvador
2013-01-22 2:34 ` Fabio Estevam
2013-01-22 1:47 ` [U-Boot] [PATCH 8/9] mxs: Fix MMC reset to avoid write errors and timeout in iMX23 Otavio Salvador
2013-01-22 1:49 ` Marek Vasut
2013-01-22 2:03 ` Otavio Salvador
2013-01-22 2:15 ` Marek Vasut [this message]
2013-01-22 1:47 ` [U-Boot] [PATCH 9/9] mx23: Use PIO mode support for MMC Otavio Salvador
2013-01-22 1:50 ` Marek Vasut
2013-01-22 1:56 ` Otavio Salvador
2013-01-22 1:59 ` Marek Vasut
2013-01-23 9:04 ` Stefano Babic
2013-01-23 11:05 ` Otavio Salvador
2013-01-23 11:26 ` Marek Vasut
2013-01-23 11:39 ` Stefano Babic
2013-01-23 11:48 ` Marek Vasut
2013-01-23 12:12 ` Otavio Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201301220315.34552.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox