From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Tue, 22 Jan 2013 03:42:21 +0100
Subject: [U-Boot] [PATCH 4/9] mx23evk: Add initial board support
In-Reply-To: <CAOMZO5A3RwAvM0=RnvVjjKdQjgmTSCUB=U_9PJKwNLmhf35e+Q@mail.gmail.com>
References: <1358819250-31625-1-git-send-email-otavio@ossystems.com.br>
	<1358819250-31625-5-git-send-email-otavio@ossystems.com.br>
	<CAOMZO5A3RwAvM0=RnvVjjKdQjgmTSCUB=U_9PJKwNLmhf35e+Q@mail.gmail.com>
Message-ID: <201301220342.22129.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Fabio Estevam,

> On Mon, Jan 21, 2013 at 11:47 PM, Otavio Salvador
> 
> <otavio@ossystems.com.br> wrote:
> > Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> > ---
> > 
> >  board/freescale/mx23evk/Makefile   |  47 +++++++
> >  board/freescale/mx23evk/mx23evk.c  |  81 ++++++++++++
> >  board/freescale/mx23evk/spl_boot.c | 115 +++++++++++++++++
> >  boards.cfg                         |   1 +
> >  include/configs/mx23evk.h          | 252
> >  +++++++++++++++++++++++++++++++++++++ 5 files changed, 496
> >  insertions(+)
> >  create mode 100644 board/freescale/mx23evk/Makefile
> >  create mode 100644 board/freescale/mx23evk/mx23evk.c
> >  create mode 100644 board/freescale/mx23evk/spl_boot.c
> >  create mode 100644 include/configs/mx23evk.h
> 
> An entry to MAINTAINERS file is missing.
> 
> > +/*
> > + * USB
> > + */
> > +#ifdef CONFIG_CMD_USB
> > +#define        CONFIG_USB_EHCI
> > +#define        CONFIG_USB_EHCI_MXS
> > +#define        CONFIG_EHCI_MXS_PORT 1
> > +#define        CONFIG_EHCI_IS_TDI
> > +#define        CONFIG_USB_STORAGE
> > +#endif
> 
> Is USB functional? If not, please remove this.

I don't think so ... besides, MX23 has only one USB port. How can this even 
compile if USBPHY1 and such values are undefined?

Best regards,
Marek Vasut