[U-Boot] [PATCH 4/9] mx23evk: Add initial board support

Marek Vasut
2013-01-22T02:42:21Z

Dear Fabio Estevam,

> On Mon, Jan 21, 2013 at 11:47 PM, Otavio Salvador
>
> <otavio@ossystems.com.br> wrote:
> > Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> > ---
> >
> > board/freescale/mx23evk/Makefile | 47 +++++++
> > board/freescale/mx23evk/mx23evk.c | 81 ++++++++++++
> > board/freescale/mx23evk/spl_boot.c | 115 +++++++++++++++++
> > boards.cfg | 1 +
> > include/configs/mx23evk.h | 252
> > +++++++++++++++++++++++++++++++++++++ 5 files changed, 496
> > insertions(+)
> > create mode 100644 board/freescale/mx23evk/Makefile
> > create mode 100644 board/freescale/mx23evk/mx23evk.c
> > create mode 100644 board/freescale/mx23evk/spl_boot.c
> > create mode 100644 include/configs/mx23evk.h
>
> An entry to MAINTAINERS file is missing.
>
> > +/*
> > + * USB
> > + */
> > +#ifdef CONFIG_CMD_USB
> > +#define CONFIG_USB_EHCI
> > +#define CONFIG_USB_EHCI_MXS
> > +#define CONFIG_EHCI_MXS_PORT 1
> > +#define CONFIG_EHCI_IS_TDI
> > +#define CONFIG_USB_STORAGE
> > +#endif
>
> Is USB functional? If not, please remove this.

I don't think so ... besides, MX23 has only one USB port. How can this even
compile if USBPHY1 and such values are undefined?

Best regards,
Marek Vasut