public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] integrator: pass a Device Tree by default
Date: Tue, 22 Jan 2013 13:04:16 +0100	[thread overview]
Message-ID: <201301221304.17153.marex@denx.de> (raw)
In-Reply-To: <CACRpkda-d_LETcxWwkBEFfZrAgMvOpxF497jNu=61ixp8+3YJg@mail.gmail.com>

Dear Linus Walleij,

> On Sun, Jan 20, 2013 at 1:53 AM, Marek Vasut <marex@denx.de> wrote:
> > Dear Linus Walleij,
> > 
> >> This, enabled the FDT library for the Integrators, updates
> >> the Integrator/CP default command to load and pass a Device
> >> Tree when booting the kernel from the on-board ethernet,
> >> define same environment for the Integrator/AP and move the
> >> load address around to something even.
> >> 
> >> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> > 
> > Shouldn't the load address be 0x8000 instead of 0x800 (it used to be
> > 0x7fc0) ?
> 
> 0x800 works fine, but honestly I don't know why Peter P ages ago chose the
> very odd address 0x7fc0.
> 
> But you know U-boot way better than me, and most things work fine it seems.
> What is a typical load address?

Heh, there ain't any "typical load address", the FDT binary is relocated at the 
end of RAM just before boot anyway, so I'm ok with any address you pick, just 
make it a sane one ;)

> > Also, "setenv loadaddr nnnn" is nonsense, just use the usual
> > CONFIG_SYS_LOAD_ADDR (which inherently sets the loadaddr env variable).
> > Or do you see a problem there?
> 
> Not really, it was mainly because there is no way to set the FDT load
> address as a variable, e.g. we don't have CONFIG_FDT_LOAD_ADDR,
> and I wanted to keep both definitions in the same place, i.e. in the
> default boot script.

Makes sense, I'll CC Albert.

> On the Integrator/AP I have to load the two pieces one at the time,
> manually using loady, so it is a bit helpful to have the address prints
> at least.

Yup.

> Yours,
> Linus Walleij

Best regards,
Marek Vasut

  reply	other threads:[~2013-01-22 12:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-20  0:49 [U-Boot] [PATCH] integrator: pass a Device Tree by default Linus Walleij
2013-01-20  0:53 ` Marek Vasut
2013-01-22  7:58   ` Linus Walleij
2013-01-22 12:04     ` Marek Vasut [this message]
2013-01-22 13:01       ` Linus Walleij
2013-01-22 13:16         ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201301221304.17153.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox