From: Allen Martin <amartin@nvidia.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] sandbox: fix compiler warning
Date: Tue, 22 Jan 2013 15:06:32 -0800 [thread overview]
Message-ID: <20130122230631.GB23767@badger> (raw)
In-Reply-To: <CAPnjgZ0TXm9t-bEuZR+CFzzOmGcGNVQ1==rrgz50cJ8hXUN80A@mail.gmail.com>
On Tue, Jan 22, 2013 at 02:58:58PM -0800, Simon Glass wrote:
> Hi Allen,
>
> On Tue, Jan 22, 2013 at 2:48 PM, Allen Martin <amartin@nvidia.com> wrote:
> > On Tue, Jan 22, 2013 at 01:56:23PM -0800, Simon Glass wrote:
> >> On Tue, Jan 22, 2013 at 1:42 PM, Allen Martin <amartin@nvidia.com> wrote:
> >> > Fix compiler warning about control flow reaching end of non void
> >> > function.
> >> >
> >> > Signed-off-by: Allen Martin <amartin@nvidia.com>
> >>
> >> Should perhaps mention the commit that adding this warning (e05e5de7 I think)
> >>
> >> Acked-by: Simon Glass <sjg@chromium.org>
> >>
> >
> > It was this commit:
> >
> > commit fec79acc864bed049b6beae719ccbf2bbec5403a
> > Author: Mike Frysinger <vapier@gentoo.org>
> > Date: Wed Oct 26 00:22:14 2011 +0000
> >
> > sandbox: drop unused return
> >
> > Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> > Acked-by: Simon Glass <sjg@chromium.org>
> >
> >
> > I'll change the commit messagen and repost and cc Mike as well.
>
> Actually I think that Mike's commit was correct at the time, and it
> was Albert's which changed the no-return behaviour of the function
> signature in common.h?
Oh I see, you're right. I'll resend.
-Allen
--
nvpublic
prev parent reply other threads:[~2013-01-22 23:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-22 21:42 [U-Boot] [PATCH] sandbox: fix compiler warning Allen Martin
2013-01-22 21:56 ` Simon Glass
2013-01-22 22:48 ` Allen Martin
2013-01-22 22:58 ` Simon Glass
2013-01-22 23:06 ` Allen Martin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130122230631.GB23767@badger \
--to=amartin@nvidia.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox