public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3] sandbox: fix compiler warning
Date: Thu, 24 Jan 2013 13:45:34 +0100	[thread overview]
Message-ID: <20130124134534.086b2e59@lilith> (raw)
In-Reply-To: <20130123210527.GA1836@badger>

Hi Allen,

On Wed, 23 Jan 2013 13:05:27 -0800, Allen Martin <amartin@nvidia.com>
wrote:

> > Shouldn't the function be given '__attribute__((noreturn))' rather than
> > adding a non-executed 'return 0' to it?
> > 
> 
> The function in question is sandbox main(), and it can return if there
> was an error prior to calling board_init_f().  Here's the whole
> function for context:
> 
> int main(int argc, char *argv[]) [...]

Makes sense, thanks.

> -Allen

Amicalement,
-- 
Albert.

  reply	other threads:[~2013-01-24 12:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-22 23:11 [U-Boot] [PATCH v3] sandbox: fix compiler warning Allen Martin
2013-01-23  6:46 ` Albert ARIBAUD
2013-01-23 21:05   ` Allen Martin
2013-01-24 12:45     ` Albert ARIBAUD [this message]
2013-02-16  0:06       ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130124134534.086b2e59@lilith \
    --to=albert.u.boot@aribaud.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox