From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Thu, 24 Jan 2013 13:45:34 +0100 Subject: [U-Boot] [PATCH v3] sandbox: fix compiler warning In-Reply-To: <20130123210527.GA1836@badger> References: <1358896281-32106-1-git-send-email-amartin@nvidia.com> <20130123074603.2949fa47@lilith> <20130123210527.GA1836@badger> Message-ID: <20130124134534.086b2e59@lilith> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Allen, On Wed, 23 Jan 2013 13:05:27 -0800, Allen Martin wrote: > > Shouldn't the function be given '__attribute__((noreturn))' rather than > > adding a non-executed 'return 0' to it? > > > > The function in question is sandbox main(), and it can return if there > was an error prior to calling board_init_f(). Here's the whole > function for context: > > int main(int argc, char *argv[]) [...] Makes sense, thanks. > -Allen Amicalement, -- Albert.